system logging API paths (#127)

* api path support: system logging action Signed-off-by: Tomas Herfert <herfik> * api path support: system logging Signed-off-by: Tomas Herfert <herfik> * docs & changelog Signed-off-by: Tomas Herfert <herfik> * typo fix Signed-off-by: Tomas Herfert <herfik> Signed-off-by: Tomas Herfert <herfik> Co-authored-by: Tomas Herfert <herfik>
ansible-collections · Nov 13, 2022 · 29247fa · 29247fa
1 parent 60427ff
commit 29247fa
Show file tree

Hide file tree

Showing 4 changed files with 32 additions and 21 deletions.
diff --git a/changelogs/fragments/127-logging.yml b/changelogs/fragments/127-logging.yml
@@ -0,0 +1,3 @@
+minor_changes:
+  - api_modify, api_info - support API paths ``system logging``, ``system logging action``
+    (https://github.com/ansible-collections/community.routeros/pull/127).
diff --git a/plugins/module_utils/_api_data.py b/plugins/module_utils/_api_data.py
@@ -2059,24 +2059,28 @@ def join_path(path):
         },
     ),
     ('system', 'logging', 'action'): APIData(
-        has_identifier=True,
+        fully_understood=True,
+        primary_keys=('name',),
         fields={
-            'bsd-syslog': KeyInfo(),
-            'disk-file-count': KeyInfo(),
-            'disk-file-name': KeyInfo(),
-            'disk-lines-per-file': KeyInfo(),
-            'disk-stop-on-full': KeyInfo(),
-            'memory-lines': KeyInfo(),
-            'memory-stop-on-full': KeyInfo(),
+            'bsd-syslog': KeyInfo(default=False),
+            'comment': KeyInfo(can_disable=True, remove_value=''),
+            'disk-file-count': KeyInfo(default=2),
+            'disk-file-name': KeyInfo(default='log'),
+            'disk-lines-per-file': KeyInfo(default=1000),
+            'disk-stop-on-full': KeyInfo(default=False),
+            'email-start-tls': KeyInfo(default=False),
+            'email-to': KeyInfo(default=''),
+            'memory-lines': KeyInfo(default=1000),
+            'memory-stop-on-full': KeyInfo(default=False),
             'name': KeyInfo(),
-            'remember': KeyInfo(),
-            'remote': KeyInfo(),
-            'remote-port': KeyInfo(),
-            'src-address': KeyInfo(),
-            'syslog-facility': KeyInfo(),
-            'syslog-severity': KeyInfo(),
-            'syslog-time-format': KeyInfo(),
-            'target': KeyInfo(),
+            'remember': KeyInfo(default=True),
+            'remote': KeyInfo(default='0.0.0.0'),
+            'remote-port': KeyInfo(default=514),
+            'src-address': KeyInfo(default='0.0.0.0'),
+            'syslog-facility': KeyInfo(default='daemon'),
+            'syslog-severity': KeyInfo(default='auto'),
+            'syslog-time-format': KeyInfo(default='bsd-syslog'),
+            'target': KeyInfo(required=True),
         },
     ),
     ('user', 'group'): APIData(
@@ -2148,12 +2152,12 @@ def join_path(path):
         },
     ),
     ('system', 'logging'): APIData(
-        has_identifier=True,
+        fully_understood=True,
         fields={
-            'action': KeyInfo(),
-            'disabled': KeyInfo(),
-            'prefix': KeyInfo(),
-            'topics': KeyInfo(),
+            'action': KeyInfo(default='memory'),
+            'disabled': KeyInfo(default=False),
+            'prefix': KeyInfo(default=''),
+            'topics': KeyInfo(default=''),
         },
     ),
     ('system', 'resource', 'irq'): APIData(

diff --git a/plugins/modules/api_info.py b/plugins/modules/api_info.py
@@ -127,6 +127,8 @@
         - system clock manual
         - system identity
         - system leds settings
+        - system logging
+        - system logging action
         - system note
         - system ntp client
         - system ntp client servers

diff --git a/plugins/modules/api_modify.py b/plugins/modules/api_modify.py
@@ -132,6 +132,8 @@
         - system clock manual
         - system identity
         - system leds settings
+        - system logging
+        - system logging action
         - system note
         - system ntp client
         - system ntp client servers