Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding "system ntp *" paths related to ROS7 #122

Merged
merged 8 commits into from
Nov 10, 2022
Merged

adding "system ntp *" paths related to ROS7 #122

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1a5a8d4
adding "system ntp *" paths related to ROS7
Nov 10, 2022
820d25e
changelog
Nov 10, 2022
37bf3cf
docs
Nov 10, 2022
f69134a
typo
Nov 10, 2022
52fbfaa
sanity fix
Nov 10, 2022
2013787
setting the correct defaults
Nov 10, 2022
726d0cb
Apply suggestions from code review
therfert Nov 10, 2022
1308044
typo
therfert Nov 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelogs/fragments/122-api.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
minor_changes:
- api_modify, api_info - support new fields and paths available in ROS7 under ``system ntp``
therfert marked this conversation as resolved.
Show resolved Hide resolved
(https://github.com/ansible-collections/community.routeros/pull/122).
31 changes: 31 additions & 0 deletions plugins/module_utils/_api_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1487,6 +1487,37 @@ def join_path(path):
'primary-ntp': KeyInfo(default='0.0.0.0'),
'secondary-ntp': KeyInfo(default='0.0.0.0'),
'server-dns-names': KeyInfo(default=''),
'servers': KeyInfo(default=''),
'mode': KeyInfo(default='unicast'),
'vrf': KeyInfo(default='main'),
},
),
('system', 'ntp', 'client', 'servers'): APIData(
primary_keys=('address', ),
fully_understood=True,
fields={
'comment': KeyInfo(can_disable=True, remove_value=''),
'disabled': KeyInfo(default=False),
'address': KeyInfo(),
'auth-key': KeyInfo(default='none'),
'iburst': KeyInfo(default=True),
'max-poll': KeyInfo(default=10),
'min-poll': KeyInfo(default=6),
},
),
('system', 'ntp', 'server'): APIData(
single_value=True,
fully_understood=True,
fields={
'auth-key': KeyInfo(default='none'),
'broadcast': KeyInfo(default=False),
'broadcast-addresses': KeyInfo(default=''),
'enabled': KeyInfo(default=False),
'local-clock-stratum': KeyInfo(default=5),
'manycast': KeyInfo(default=False),
'multicast': KeyInfo(default=False),
'use-local-clock': KeyInfo(default=False),
'vrf': KeyInfo(default='main'),
},
),
('system', 'package', 'update'): APIData(
Expand Down
2 changes: 2 additions & 0 deletions plugins/modules/api_info.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,8 @@
- system leds settings
- system note
- system ntp client
- system ntp client servers
- system ntp server
- system package update
- system routerboard settings
- system upgrade mirror
Expand Down
2 changes: 2 additions & 0 deletions plugins/modules/api_modify.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,8 @@
- system leds settings
- system note
- system ntp client
- system ntp client servers
- system ntp server
- system package update
- system routerboard settings
- system upgrade mirror
Expand Down