Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding "system ntp *" paths related to ROS7 #122

Merged
merged 8 commits into from
Nov 10, 2022

Conversation

therfert
Copy link
Contributor

SUMMARY

support more system ntp related API paths and fields available on ROS7

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

api_info
api_modify

ADDITIONAL INFORMATION

none

Tomas Herfert added 3 commits November 10, 2022 08:34
Signed-off-by: Tomas Herfert <herfik>
Signed-off-by: Tomas Herfert <herfik>
Signed-off-by: Tomas Herfert <herfik>
@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Merging #122 (1308044) into main (c2e58c3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #122   +/-   ##
=======================================
  Coverage   87.64%   87.64%           
=======================================
  Files          28       28           
  Lines        3496     3496           
  Branches      618      618           
=======================================
  Hits         3064     3064           
  Misses        305      305           
  Partials      127      127           
Flag Coverage Δ
integration 66.86% <ø> (ø)
sanity 22.48% <ø> (ø)
units 87.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugins/module_utils/_api_data.py 95.91% <ø> (ø)
plugins/modules/api_info.py 89.23% <ø> (ø)
plugins/modules/api_modify.py 79.90% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Tomas Herfert <herfik>
@github-actions
Copy link

github-actions bot commented Nov 10, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

Signed-off-by: Tomas Herfert <herfik>
@therfert therfert marked this pull request as ready for review November 10, 2022 10:26
@therfert therfert marked this pull request as draft November 10, 2022 15:03
Signed-off-by: Tomas Herfert <herfik>
@therfert therfert marked this pull request as ready for review November 10, 2022 16:54
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides that, LGTM.

changelogs/fragments/122-api.yml Outdated Show resolved Hide resolved
@felixfontein
Copy link
Collaborator

Thanks for fixing the typo. The r key on my laptop's keyboard is in the process of falling off, I really have to get it replaced... :)

@felixfontein felixfontein merged commit 1e36dfa into ansible-collections:main Nov 10, 2022
@felixfontein
Copy link
Collaborator

@therfert thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants