Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

postgresql_ping, postgresql_info: fix crash related to PgSQL version parsing #43

Merged
merged 2 commits into from
Jan 15, 2021
Merged

postgresql_ping, postgresql_info: fix crash related to PgSQL version parsing #43

merged 2 commits into from
Jan 15, 2021

Conversation

Andersson007
Copy link
Collaborator

SUMMARY

Fixes #40

>>> raw = 'PostgreSQL 11.6, compiled by Visual C++ build 1800, 64-bit'
>>> raw = raw.split()[1].split('.')
>>> raw
['11', '6,']
>>> int(raw[1].rstrip(','))
6
ISSUE TYPE
  • Bugfix Pull Request

@Andersson007 Andersson007 mentioned this pull request Jan 15, 2021
Closed
@Andersson007
Copy link
Collaborator Author

ready_for_review

tcraxs
tcraxs approved these changes Jan 15, 2021
View reviewed changes
Copy link
Contributor

@tcraxs tcraxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Andersson007
Copy link
Collaborator Author

@joaocc thanks for reporting the issue!
@tcraxs thanks for reviewing!

@Andersson007 Andersson007 merged commit b6d399e into ansible-collections:main Jan 15, 2021
@Andersson007 Andersson007 mentioned this pull request Jan 19, 2021
Merged
@Andersson007 Andersson007 mentioned this pull request Feb 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcraxs tcraxs tcraxs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

postgresql_ping fails when connecting to Azure postgresql (version has text after minor version)
2 participants
@Andersson007 @tcraxs