Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable-1] Various backports from community.postgres #1789

Merged
merged 6 commits into from
Feb 11, 2021
Merged

[stable-1] Various backports from community.postgres #1789

merged 6 commits into from
Feb 11, 2021

Conversation

Andersson007
Copy link
Contributor

@felixfontein
Copy link
Collaborator

/rebuild

@felixfontein felixfontein reopened this Feb 11, 2021
@felixfontein
Copy link
Collaborator

This should also restart the AZP tests :)

felixfontein
felixfontein reviewed Feb 11, 2021
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I manually compared all code changes. I found two small differences, my suggestion would be to also apply them so the code is more similar (might make it easier to apply more backports in the future).

And then there's a detail in the changelog ;-)

plugins/modules/database/postgresql/postgresql_set.py Show resolved Hide resolved
plugins/modules/database/postgresql/postgresql_set.py Outdated Show resolved Hide resolved
changelogs/fragments/1-community-postgresql_backports.yml Outdated Show resolved Hide resolved
@Andersson007
Copy link
Contributor Author

I manually compared all code changes. I found two small differences, my suggestion would be to also apply them so the code is more similar (might make it easier to apply more backports in the future).

And then there's a detail in the change

All committed, thanks very much for comparing!:)

@felixfontein felixfontein merged commit 3a2e614 into ansible-collections:stable-1 Feb 11, 2021
@felixfontein
Copy link
Collaborator

@Andersson007 thanks for backporting these fixes!

@Andersson007
Copy link
Contributor Author

@felixfontein thanks for reviewing and merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug community_review database integration tests/integration module module needs_triage new_module New module new_plugin New plugin postgresql tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Andersson007 @felixfontein @ansibullbot