[PR #138/3f3e0d05 backport][stable-1] Update routeros.py #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
* Update routeros.py Adjust the terminal detection line to support forward slashes in device hostnames (connections fail without clear reason otherwise) * Add changelog fragment. Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 3f3e0d0)
felixfontein
deleted the
patchback/backports/stable-1/3f3e0d05a12124bed614a6790bcc23e610835a43/pr-138
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #138 as merged into main (3f3e0d0).
Adjust the terminal detection line to support forward slashes in device hostnames (connections fail without clear reason otherwise)
SUMMARY
My RouterOS units have forward slashes in their system identities. The way the regex is structured prevents terminal detection from succeeding in this case, and devices will fail silently. The regex is still probably overly strict, but it fixed my problem.
ISSUE TYPE