Update routeros.py

[svliron]

Adjust the terminal detection line to support forward slashes in device hostnames (connections fail without clear reason otherwise)

SUMMARY

My RouterOS units have forward slashes in their system identities. The way the regex is structured prevents terminal detection from succeeding in this case, and devices will fail silently. The regex is still probably overly strict, but it fixed my problem.

ISSUE TYPE

• Bugfix Pull Request

[felixfontein]

Thanks for this fix! This also needs a changelog fragment.

BTW, we started moving the routeros plugins and modules to a new repository yesterday: https://github.com/ansible-collections/community.routeros Since we plan to backport bugfixes to this repository anyway, I guess we can also merge this PR here and then 'foreport' it to the new repo. I hope that's OK for everyone.

CC @heuels

[heuels]

Thanks for the contribution!

[felixfontein]

@svliron once the changelog fragment is there (and looks good), I'll merge.

[igloo777]

@svliron are you sure that hostname syntax convention allows to use slashes in hostnames?

[felixfontein]

@igloo777 which "hostname syntax convention" do you mean? Could you please elaborate? RouterOS seems to accept hostnames which include slashes (otherwise we wouldn't have this issue/PR).

[felixfontein]

For the changelog fragments, what do you all think of:

bugfixes:
- "routeros terminal plugin - allow slashes in hostnames for terminal detection. Without this, slashes in hostnames will result in connection timeouts (https://github.com/ansible-collections/community.network/pull/138)."

[igloo777]

@igloo777 which "hostname syntax convention" do you mean? Could you please elaborate? RouterOS seems to accept hostnames which include slashes (otherwise we wouldn't have this issue/PR).

https://tools.ietf.org/html/rfc952

RouterOS may accept any symbols in identity (I want emoji). But then RouterOS should have dedicated hostname option in config.

[igloo777]

For the changelog fragments, what do you all think of:

bugfixes:
- "routeros terminal plugin - allow slashes in hostnames for terminal detection. Without this, slashes in hostnames will result in connection timeouts (https://github.com/ansible-collections/community.network/pull/138)."

IMHo, better to break an execution with "rfc952 breaking symbol symbol found in hostname, fix your hostname" message in err output.

[felixfontein]

Feel free to create a PR to implement that. But be warned, it's not trivial, since you have to modify code in another collection for that (https://github.com/ansible-collections/ansible.netcommon/blob/c2aa1d6981d9dd5d6e824fdfae2df7c5eef46f50/plugins/connection/network_cli.py#L996-L1050).

[felixfontein]

Once CI passes, I'll merge as this clearly improves the current situation. I'll also fore-port it to the community.routeros repo.

[felixfontein]

@svliron thanks for the PR!
@heuels @igloo777 thanks for your reviews and comments!