Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

Improve k8s Deployment and Daemonset wait conditions #87

Closed

Conversation

willthames
Copy link
Collaborator

@willthames willthames commented May 4, 2020

SUMMARY

Ensure that Deployments and Daemonsets properly await
all replicas to be available. Correctly handles the
subtle edge case when a service account no longer exists.

Note that this will dramatically slow Daemonset updates

Testing this identified that scale was no longer working
so rectify scaling too

Fixes ansible/ansible#66344

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

k8s/raw

Ensure that Deployments and Daemonsets properly await
all replicas to be available. Correctly handles the
subtle edge case when a service account no longer exists.

Note that this will dramatically slow Daemonset updates

Testing this identified that scale was no longer working
so rectify scaling too
@codecov
Copy link

codecov bot commented May 4, 2020

Codecov Report

Merging #87 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #87   +/-   ##
=======================================
  Coverage   43.33%   43.33%           
=======================================
  Files           3        3           
  Lines         540      540           
  Branches      109      109           
=======================================
  Hits          234      234           
  Misses        263      263           
  Partials       43       43           
Impacted Files Coverage Δ
...s/community/kubernetes/plugins/module_utils/raw.py 39.16% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4de52c5...6028633. Read the comment docs.

@willthames
Copy link
Collaborator Author

If adding 200 lines to the test suite doesn't affect the code coverage, I'm not really sure what the point of the code coverage check is

@willthames
Copy link
Collaborator Author

Duplicate of #35 which has plenty of comments so I'll resolve those

@willthames willthames closed this May 14, 2020
@willthames willthames deleted the k8s_wait_conditions branch May 14, 2020 09:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

k8s_scale is getting failed with error: "msg": "Exception reading event stream: "
1 participant