K8s apply check mode fix #84
Conversation
apply_object returns only the patch - we need to actually apply the patch to the existing object. Fixes ansible/ansible#66780
Codecov Report
@@ Coverage Diff @@
## master #84 +/- ##
==========================================
- Coverage 43.33% 43.09% -0.24%
==========================================
Files 3 3
Lines 540 543 +3
Branches 109 110 +1
==========================================
Hits 234 234
- Misses 263 266 +3
Partials 43 43
Continue to review full report at Codecov.
|
|
There is an intermittent test failure (there is a race condition) that is fixed by #87 |
There was a problem hiding this comment.
Left one quick comment/question for feedback but otherwise this LGTM. And @willthames I don't know any way to have the codecov system (which is kind of dictated by the community leadership for collections that are going to be in the ACD 2.10 distribution) account for molecule tests, unfortunately, only pytest code coverage written in Python, I guess.
SUMMARY
Adds test for applying a Service change in check_mode and ensures that test passes
Fixes ansible/ansible#66780
ISSUE TYPE
COMPONENT NAME
k8s/raw
ADDITIONAL INFORMATION
Needs backporting to ansible/ansible for 2.9