This repository has been archived by the owner on Jun 13, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #349 +/- ##
=======================================
Coverage 36.80% 36.80%
=======================================
Files 3 3
Lines 758 758
Branches 148 148
=======================================
Hits 279 279
Misses 430 430
Partials 49 49 Continue to review full report at Codecov.
|
Akasurde
reviewed
Jan 18, 2021
Akasurde
force-pushed
the
296-skip-crds
branch
from
January 29, 2021 07:14
aae4b49
to
239b9ae
Compare
Akasurde
approved these changes
Jan 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This adds an option to skip the installation of CRDs when installing or upgrading a chart. Closes ansible-collections#296.
Signed-off-by: Mike Graves <[email protected]> Signed-off-by: Abhijeet Kasurde <[email protected]>
Akasurde
force-pushed
the
296-skip-crds
branch
from
February 3, 2021 08:19
239b9ae
to
601c863
Compare
tima
approved these changes
Feb 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This repository does not accept pull requests, see the README for details. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This adds an option to skip the installation of CRDs when installing or
upgrading a chart.
Closes #296.
ISSUE TYPE
COMPONENT NAME
helm