Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

Add skip_crds option to helm #349

Merged
merged 3 commits into from
Feb 9, 2021

Conversation

gravesm
Copy link
Member

@gravesm gravesm commented Jan 15, 2021

SUMMARY

This adds an option to skip the installation of CRDs when installing or
upgrading a chart.

Closes #296.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

helm

@codecov
Copy link

codecov bot commented Jan 15, 2021

Codecov Report

Merging #349 (02621da) into main (2640084) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #349   +/-   ##
=======================================
  Coverage   36.80%   36.80%           
=======================================
  Files           3        3           
  Lines         758      758           
  Branches      148      148           
=======================================
  Hits          279      279           
  Misses        430      430           
  Partials       49       49           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2640084...601c863. Read the comment docs.

@gravesm gravesm requested review from Akasurde and goneri January 15, 2021 19:26
Copy link
Member

@Akasurde Akasurde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This adds an option to skip the installation of CRDs when installing or
upgrading a chart.

Closes ansible-collections#296.
Signed-off-by: Mike Graves <[email protected]>
Signed-off-by: Abhijeet Kasurde <[email protected]>
Copy link
Collaborator

@tima tima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Akasurde Akasurde merged commit 80b9140 into ansible-collections:main Feb 9, 2021
@gravesm gravesm deleted the 296-skip-crds branch February 19, 2021 17:58
@github-actions
Copy link

github-actions bot commented Nov 4, 2021

This repository does not accept pull requests, see the README for details.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants