Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

Support for --skip-crds with helm v3 cli #296

Closed
stephenmoloney opened this issue Nov 8, 2020 · 7 comments
Closed

Support for --skip-crds with helm v3 cli #296

stephenmoloney opened this issue Nov 8, 2020 · 7 comments
Assignees
@gravesm
Labels
priority/low topic/helm Issues relating to helm plugins type/enhancement New feature or request

Comments

@stephenmoloney
Copy link

stephenmoloney commented Nov 8, 2020 •
edited
Loading

SUMMARY

Support for --skip-crds with helm v3 cli

ISSUE TYPE

Support for --skip-crds with helm v3 cli

COMPONENT NAME

helm

ADDITIONAL INFORMATION

This is sometimes desired behaviour or required behaviour
@tima tima added the type/enhancement New feature or request label Nov 8, 2020
@tima
Copy link
Collaborator

tima commented Nov 8, 2020

@stephenmoloney Thanks for filing this. Could you expand your description on the uses cases for this feature? Why and when would you use this. Why is this important. Things that "sell" the idea for inclusion in a future release.

@tima tima added the topic/helm Issues relating to helm plugins label Nov 8, 2020
@stephenmoloney
Copy link
Author

@tima
Sure. But essentially the reason for inclusion of --skip-crds will be the same reason as helm cli includes it.
Give me some time and I will document this

The tricky part will be the difference in behavior and how this is achieved between helm v3 and helm v2.
How is the ansible module going to handle differences between them.

Does it try to abstract those differences away and support on both versions - that will make this a bit problematic.

@tima
Copy link
Collaborator

tima commented Nov 9, 2020

@stephenmoloney The helm modules in here only support Helm3. We have no intention of supporting Helm2. There is a deprecated helm module that kind of does that. (It's based on a python library that wasn't keeping up with helm2 and went unmaintained.)

@stephenmoloney
Copy link
Author

Ok @tima

That is a good thing.

Then I definitely think --skip-crds should be supported in the same way as arguments like atomic and wait-timeout are.

@Akasurde
Copy link
Member

@stephenmoloney Are you working on the PR? Let me know.

@stephenmoloney
Copy link
Author

stephenmoloney commented Nov 10, 2020 •
edited
Loading

Gimme a bit of time. I will let you know within 1 month. (I have a workaround for this issue now)

@stephenmoloney
Copy link
Author

@Akasurde I won't be able to get to this soon I'm afraid.

gravesm added a commit to gravesm/community.kubernetes that referenced this issue Jan 15, 2021
@gravesm
Add skip_crds option to helm
92d17e3 
This adds an option to skip the installation of CRDs when installing or
upgrading a chart.

Closes ansible-collections#296.
@gravesm gravesm mentioned this issue Jan 15, 2021
Merged
Akasurde pushed a commit to gravesm/community.kubernetes that referenced this issue Feb 3, 2021
@gravesm @Akasurde
Add skip_crds option to helm
e98ef31 
This adds an option to skip the installation of CRDs when installing or
upgrading a chart.

Closes ansible-collections#296.
Akasurde pushed a commit that referenced this issue Feb 9, 2021
@gravesm
Add skip_crds option to helm (#349)
80b9140 
This adds an option to skip the installation of CRDs when installing or
upgrading a chart.

Closes: #296
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gravesm gravesm

Labels
priority/low topic/helm Issues relating to helm plugins type/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tima @Akasurde @gravesm @stephenmoloney