Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

k8s: Handle ValueError raised #330

Merged
merged 1 commit into from
Jan 12, 2021
Merged

Conversation

Akasurde
Copy link
Member

SUMMARY

API raises ValueError when namespace is not provided in
definition. Handle and provide meaningful message to user
about this.

Signed-off-by: Abhijeet Kasurde [email protected]

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

changelogs/fragments/handle_valueerror.yml
plugins/module_utils/common.py

@codecov
Copy link

codecov bot commented Dec 10, 2020

Codecov Report

Merging #330 (f18a03e) into main (a6cb6c4) will decrease coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #330      +/-   ##
==========================================
- Coverage   37.12%   36.87%   -0.25%     
==========================================
  Files           3        3              
  Lines         738      743       +5     
  Branches      143      145       +2     
==========================================
  Hits          274      274              
- Misses        415      420       +5     
  Partials       49       49              
Impacted Files Coverage Δ
...ommunity/kubernetes/plugins/module_utils/common.py 35.64% <0.00%> (-0.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6cb6c4...f18a03e. Read the comment docs.

@Akasurde Akasurde requested review from goneri, gravesm and tima December 10, 2020 06:48
API raises ValueError when namespace is not provided in
definition. Handle and provide meaningful message to user
about this.

Signed-off-by: Abhijeet Kasurde <[email protected]>
Copy link
Member

@gravesm gravesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants