k8s: Handle ValueError raised

API raises ValueError when namespace is not provided in definition. Handle and provide meaningful message to user about this. Signed-off-by: Abhijeet Kasurde <[email protected]>
ansible-collections · Dec 10, 2020 · 6e1ef57 · 6e1ef57
1 parent 549dd26
commit 6e1ef57
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/changelogs/fragments/handle_valueerror.yml b/changelogs/fragments/handle_valueerror.yml
@@ -0,0 +1,2 @@
+bugfixes:
+- k8s - handle ValueError when namespace is not provided.
diff --git a/plugins/module_utils/common.py b/plugins/module_utils/common.py
@@ -708,6 +708,11 @@ def perform_action(self, resource, definition):
                         if self.warnings:
                             msg += "\n" + "\n    ".join(self.warnings)
                         self.fail_json(msg=msg, error=exc.status, status=exc.status, reason=exc.reason)
+                    except Exception as exc:
+                        msg = "Failed to create object: {0}".format(exc)
+                        if self.warnings:
+                            msg += "\n" + "\n    ".join(self.warnings)
+                        self.fail_json(msg=msg, error='', status='', reason='')
                 success = True
                 result['result'] = k8s_obj
                 if wait and not self.check_mode:
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		bugfixes:
		- k8s - handle ValueError when namespace is not provided.