-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a workflow looking for changelog fragments #247
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dear contributor,
Thank you for you Pull Request !
To ease the work of maintainers you need to add a changelog fragment in you PR.
It will help your change be released faster !
Thank you !
Codecov Report
@@ Coverage Diff @@
## main #247 +/- ##
=======================================
Coverage 68.83% 68.83%
=======================================
Files 16 16
Lines 1707 1707
Branches 318 318
=======================================
Hits 1175 1175
Misses 398 398
Partials 134 134
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dear contributor,
Thank you for you Pull Request !
To ease the work of maintainers you need to add a changelog fragment in you PR.
It will help your change be released faster !
Thank you !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dear contributor,
Thank you for you Pull Request !
To ease the work of maintainers you need to add a changelog fragment in you PR.
It will help your change be released faster !
Thank you !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dear contributor,
Thank you for you Pull Request !
To ease the work of maintainers you need to add a changelog fragment in you PR.
It will help your change be released faster !
Thank you !
Limitations: - The comment asking for the fragment will be posted at each push on the PR until the fragment is present. Closes:: #186
SUMMARY
Add a workflow that will check that a changelog fragment is present in the PR.
If not, a review will be posted on the PR asking for the change. If file is present, the PR will be approved by the action.
The CI will still require a code owner review and merge from maintainer.