Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a workflow looking for changelog fragments #247

Merged
merged 1 commit into from
Jun 25, 2022
Merged

Add a workflow looking for changelog fragments #247

merged 1 commit into from
Jun 25, 2022

Conversation

rrey
Copy link
Collaborator

@rrey rrey commented May 1, 2022

SUMMARY

Add a workflow that will check that a changelog fragment is present in the PR.
If not, a review will be posted on the PR asking for the change. If file is present, the PR will be approved by the action.

The CI will still require a code owner review and merge from maintainer.

@rrey rrey requested review from gundalow and seuf as code owners May 1, 2022 17:14
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear contributor,

Thank you for you Pull Request !
To ease the work of maintainers you need to add a changelog fragment in you PR.

It will help your change be released faster !
Thank you !

@codecov
Copy link

codecov bot commented May 1, 2022

Codecov Report

Merging #247 (078e059) into main (a820865) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #247   +/-   ##
=======================================
  Coverage   68.83%   68.83%           
=======================================
  Files          16       16           
  Lines        1707     1707           
  Branches      318      318           
=======================================
  Hits         1175     1175           
  Misses        398      398           
  Partials      134      134           
Flag Coverage Δ
integration 67.26% <ø> (ø)
sanity 22.84% <ø> (ø)
units 73.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a820865...078e059. Read the comment docs.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear contributor,

Thank you for you Pull Request !
To ease the work of maintainers you need to add a changelog fragment in you PR.

It will help your change be released faster !
Thank you !

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear contributor,

Thank you for you Pull Request !
To ease the work of maintainers you need to add a changelog fragment in you PR.

It will help your change be released faster !
Thank you !

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear contributor,

Thank you for you Pull Request !
To ease the work of maintainers you need to add a changelog fragment in you PR.

It will help your change be released faster !
Thank you !

@pr-triage pr-triage bot removed the PR: unreviewed label May 1, 2022
Limitations:
- The comment asking for the fragment will be posted at each push on the
  PR until the fragment is present.

Closes:: #186
@rrey rrey enabled auto-merge (rebase) June 25, 2022 08:23
@rrey rrey disabled auto-merge June 25, 2022 08:24
@rrey rrey merged commit 653fac2 into main Jun 25, 2022
@rrey rrey deleted the check_fragment branch June 25, 2022 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant