Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc fragment check on PR with gh actions #186

Closed
rrey opened this issue Sep 14, 2021 · 1 comment
Closed

Doc fragment check on PR with gh actions #186

rrey opened this issue Sep 14, 2021 · 1 comment
Labels
CI Continuous Integration feature/idea help_needed

Comments

@rrey
Copy link
Collaborator

rrey commented Sep 14, 2021

SUMMARY

Collections requires that semver is followed and that we have clean release message listing all changes by severity.
Contributors often forget to include the doc fragment in their PR, we could automatically have the PR reviewed to "Request changes" by a bot that would check that the PR contains a doc fragment.

ISSUE TYPE
  • Feature Idea
COMPONENT NAME

CI
@rrey rrey added feature/idea help_needed CI Continuous Integration labels Sep 14, 2021
rrey added a commit that referenced this issue May 1, 2022
@rrey
Add a workflow looking for changelog fragments
931921b 
Closes:: #186
rrey added a commit that referenced this issue May 1, 2022
@rrey
Add a workflow looking for changelog fragments
642f878 
Closes:: #186
rrey added a commit that referenced this issue May 1, 2022
@rrey
Add a workflow looking for changelog fragments
9cf0981 
Closes:: #186
rrey added a commit that referenced this issue May 1, 2022
@rrey
Add a workflow looking for changelog fragments
da0d453 
Closes:: #186
rrey added a commit that referenced this issue May 1, 2022
@rrey
Add a workflow looking for changelog fragments
5bdc5d5 
Closes:: #186
rrey added a commit that referenced this issue May 1, 2022
@rrey
Add a workflow looking for changelog fragments
539a918 
Closes:: #186
rrey added a commit that referenced this issue May 1, 2022
@rrey
Add a workflow looking for changelog fragments
511883f 
Closes:: #186
rrey added a commit that referenced this issue May 1, 2022
@rrey
Add a workflow looking for changelog fragments
078e059 
Limitations:
- The comment asking for the fragment will be posted at each push on the
  PR until the fragment is present.

Closes:: #186
rrey added a commit that referenced this issue Jun 25, 2022
@rrey
Add a workflow looking for changelog fragments
653fac2 
Limitations:
- The comment asking for the fragment will be posted at each push on the
  PR until the fragment is present.

Closes:: #186
@rrey
Copy link
Collaborator Author

rrey commented Jun 25, 2022

Resolved by #247

@rrey rrey closed this as completed Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI Continuous Integration feature/idea help_needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rrey