-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable-1] Add missing no_log=True #2018
Merged
felixfontein
merged 1 commit into
ansible-collections:stable-1
from
felixfontein:missing-no_log
Mar 13, 2021
Merged
[stable-1] Add missing no_log=True #2018
felixfontein
merged 1 commit into
ansible-collections:stable-1
from
felixfontein:missing-no_log
Mar 13, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
affects_2.10
bug
This issue/PR relates to a bug
module
module
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR
needs_triage
new_module
New module
new_plugin
New plugin
plugins
plugin (any type)
small_patch
Hopefully easy to review
storage
community_review
and removed
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR
labels
Mar 13, 2021
lonico
approved these changes
Mar 13, 2021
bmillemathias
approved these changes
Mar 13, 2021
@lonico @bmillemathias thanks a lot for reviewing this! |
Thank you @felixfontein |
felixfontein
added a commit
to felixfontein/ansible
that referenced
this pull request
Mar 13, 2021
felixfontein
added a commit
to felixfontein/ansible
that referenced
this pull request
Mar 15, 2021
relrod
pushed a commit
to ansible/ansible
that referenced
this pull request
Apr 3, 2021
relrod
pushed a commit
to ansible/ansible
that referenced
this pull request
Apr 3, 2021
clrpackages
pushed a commit
to clearlinux-pkgs/ansible
that referenced
this pull request
Apr 15, 2021
…2.9.20 Alina Buzachis (1): New AWS module mod_defaults - rds_option_group (_info) modules (#74098) Carlos Camacho (1): [stable-2.9] Fix: nmcli bridge-slave fails with error (#74125) Felix Fontein (4): Backport of ansible-collections/community.docker#103. (#73890) Backport of ansible-collections/community.aws#475. (#73894) Backport of ansible-collections/community.general#2018. (#73893) Backport of ansible-collections/community.network#223. (#73909) Jill R (1): New AWS module mod_defaults - wafv2 modules (#73975) Mark Chappell (3): Ensure unit test paths for connection and inventory plugins are based on the context (#73877) Partial backport of community.aws/471 - no_log=True for aws_secret (#73874) [backport/2.9] module_defaults: Add rds_snapshot (#74113) Matt Clay (1): [stable-2.9] Fix ansible-test coverage exporting. Matt Martz (1): [stable-2.9] Ensure task from the worker is finalized/squashed (#73881) (#73929) Rick Elrod (5): Update Ansible release version to v2.9.19.post0. [security] Add more missing no_logs (#74115) New release v2.9.20rc1 Update Ansible release version to v2.9.20rc1.post0. New release v2.9.20 Sam Doran (2): Move file needed by cs_volume test to S3 [stable-2.9] find - set proper default based on use_regex (#73961) (#73966) Xabier Napal (1): Fix wrong backup directory var name in apt module (#73840) (#74003) nitzmahone (1): add optional module_utils import support (#73832) (#73916)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
This issue/PR relates to a bug
community_review
module
module
needs_triage
new_module
New module
new_plugin
New plugin
plugins
plugin (any type)
small_patch
Hopefully easy to review
storage
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adds two missing
no_log=True
in two deprecated modules that were removed in community.general 2.0.0.In the modules that replace these modules, the issue has already been fixed (ansible-collections/netapp@a2d3b96#diff-cbb7bcd7441934dc6d76359036460841f01deb56bacce6813ae7935ebacc810cR151) or has never been there in the first place (ansible-collections/netapp@c6018a8).
CC @gundalow @relrod
ISSUE TYPE
COMPONENT NAME
na_cdot_user
sf_account_manager