Skip to content

Commit

Permalink
Add missing no_log values. (#2018)
Browse files Browse the repository at this point in the history
  • Loading branch information
felixfontein authored Mar 13, 2021
1 parent d0fa506 commit b0cbef3
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
3 changes: 3 additions & 0 deletions changelogs/fragments/missing-no_log-again.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
security_fixes:
- "na_cdot_user - mark the ``set_password`` parameter as ``no_log`` to avoid leakage of secrets (https://github.com/ansible-collections/community.general/pull/2018)."
- "sf_account_manager - mark the ``initiator_secret`` and ``target_secret`` parameters as ``no_log`` to avoid leakage of secrets (https://github.com/ansible-collections/community.general/pull/2018)."
2 changes: 1 addition & 1 deletion plugins/modules/storage/netapp/na_cdot_user.py
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ def __init__(self):
choices=['community', 'password',
'publickey', 'domain',
'nsswitch', 'usm']),
set_password=dict(required=False, type='str', default=None),
set_password=dict(required=False, type='str', default=None, no_log=True),
role_name=dict(required=False, type='str'),

vserver=dict(required=True, type='str'),
Expand Down
4 changes: 2 additions & 2 deletions plugins/modules/storage/netapp/sf_account_manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,8 @@ def __init__(self):
account_id=dict(required=False, type='int', default=None),

new_name=dict(required=False, type='str', default=None),
initiator_secret=dict(required=False, type='str'),
target_secret=dict(required=False, type='str'),
initiator_secret=dict(required=False, type='str', no_log=True),
target_secret=dict(required=False, type='str', no_log=True),
attributes=dict(required=False, type='dict'),
status=dict(required=False, type='str'),
))
Expand Down

0 comments on commit b0cbef3

Please sign in to comment.