Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker_compose_v2: ignore some pull events #803

Merged
merged 2 commits into from
Feb 23, 2024
Merged

docker_compose_v2: ignore some pull events #803

merged 2 commits into from
Feb 23, 2024

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

Fixes #802.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

docker_compose_v2

@felixfontein felixfontein added the docker-compose-v2 Docker Compose v2 label Feb 22, 2024
@felixfontein
Copy link
Collaborator Author

TODO: potentially also make check mode behavior configurable.

@felixfontein
Copy link
Collaborator Author

Hmm, that TODO is not implementable, as the behavior comes from Docker Compose:

" DRY-RUN MODE -  foobar Pulling ",
" DRY-RUN MODE -  foobar Pulled ",
" DRY-RUN MODE -  Container compose-foobar-1  Recreate",
" DRY-RUN MODE -  Container compose-foobar-1  Recreated",
" DRY-RUN MODE -  Container a756aaa76d8c_compose-foobar-1  Starting",
" DRY-RUN MODE -  Container a756aaa76d8c_compose-foobar-1  Started"

@felixfontein felixfontein mentioned this pull request Feb 23, 2024
Closed
@felixfontein felixfontein merged commit 6f5d678 into ansible-collections:main Feb 23, 2024
122 of 123 checks passed
@felixfontein felixfontein deleted the pull-changes branch February 23, 2024 17:24
This was referenced Mar 10, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docker-compose-v2 Docker Compose v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docker_compose_v2: Pull always check behavior to ignore pulls
1 participant
@felixfontein