Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker_compose_v2: Pull always check behavior to ignore pulls #802

Closed
saibotk opened this issue Feb 22, 2024 · 3 comments · Fixed by #803
Closed

docker_compose_v2: Pull always check behavior to ignore pulls #802

saibotk opened this issue Feb 22, 2024 · 3 comments · Fixed by #803
Labels
docker-compose-v2 Docker Compose v2 enhancement New feature or request

Comments

@saibotk
Copy link

saibotk commented Feb 22, 2024

SUMMARY

I am using pull: always to ensure that docker images that have been rebuilt on the same tag are also always pulled.
But with the pull option set to always, the module will always report a change. I think we might be able to detect if it has actually pulled something or not via the output.

Ideally the step should only be marked as changed, when the containers were recreated.
I saw that you, @felixfontein, already did something similar in #797, can we maybe introduce that to the docker_compose_v2 module too?

ISSUE TYPE
  • Feature Idea
COMPONENT NAME

docker_compose_v2

Thanks!
And huge thanks for migrating to compose v2! I could finally remove all the ugly workarounds for the python library installation <3 you're amazing.

@felixfontein felixfontein added enhancement New feature or request docker-compose-v2 Docker Compose v2 labels Feb 22, 2024
@felixfontein
Copy link
Collaborator

The kind of checks used for docker_container won't work here since the output is usually not sufficient. But considering Pulling only when a container is (re-)created is a good idea, that should work.

@felixfontein
Copy link
Collaborator

#803 fixes this.

@saibotk
Copy link
Author

saibotk commented Feb 23, 2024

Amazing thank you so much for the quick implementation ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker-compose-v2 Docker Compose v2 enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants