You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am using pull: always to ensure that docker images that have been rebuilt on the same tag are also always pulled.
But with the pull option set to always, the module will always report a change. I think we might be able to detect if it has actually pulled something or not via the output.
Ideally the step should only be marked as changed, when the containers were recreated.
I saw that you, @felixfontein, already did something similar in #797, can we maybe introduce that to the docker_compose_v2 module too?
ISSUE TYPE
Feature Idea
COMPONENT NAME
docker_compose_v2
Thanks!
And huge thanks for migrating to compose v2! I could finally remove all the ugly workarounds for the python library installation <3 you're amazing.
The text was updated successfully, but these errors were encountered:
The kind of checks used for docker_container won't work here since the output is usually not sufficient. But considering Pulling only when a container is (re-)created is a good idea, that should work.
SUMMARY
I am using
pull: always
to ensure that docker images that have been rebuilt on the same tag are also always pulled.But with the pull option set to always, the module will always report a change. I think we might be able to detect if it has actually pulled something or not via the output.
Ideally the step should only be marked as changed, when the containers were recreated.
I saw that you, @felixfontein, already did something similar in #797, can we maybe introduce that to the docker_compose_v2 module too?
ISSUE TYPE
COMPONENT NAME
docker_compose_v2
Thanks!
And huge thanks for migrating to compose v2! I could finally remove all the ugly workarounds for the python library installation <3 you're amazing.
The text was updated successfully, but these errors were encountered: