Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_certificate - add starttls option with support for mysql #264

Merged

Conversation

Ajpantuso
Copy link
Collaborator

@Ajpantuso Ajpantuso commented Aug 12, 2021

SUMMARY

Adds a starttls option to allow users to retrieve certificates from MySQL servers.
Fixes #262

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

plugins/modules/get_certificate.py

ADDITIONAL INFORMATION
  • Naïve implementation which does not check for the version/validity of the initial handshake from the MySQL server.

Reference links:

@Ajpantuso
Copy link
Collaborator Author

@markuman would you be able to try testing this PR locally? I had success with a MySQL server, but would like some more confirmation.

Copy link
Member

@markuman markuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice @Ajpantuso
works for me. tested against proxysql 2.1.1 and aws rds mariadb 10.4.

@Ajpantuso Ajpantuso changed the title [WIP] get_certificate - add starttls option with support for mysql get_certificate - add starttls option with support for mysql Aug 12, 2021
@Ajpantuso Ajpantuso marked this pull request as ready for review August 12, 2021 18:36
Copy link
Contributor

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Works well :) I've just one small suggestion:

plugins/modules/get_certificate.py Outdated Show resolved Hide resolved
@felixfontein felixfontein merged commit b59846b into ansible-collections:main Aug 15, 2021
@felixfontein
Copy link
Contributor

@Ajpantuso thanks a lot for implementing this!
@markuman thanks for reviewing and suggesting this!

@Ajpantuso Ajpantuso deleted the get_certificate_starttls branch August 16, 2021 23:29
@felixfontein felixfontein mentioned this pull request Aug 27, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add parameter to change starttls protocol
3 participants