-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
get_certificate - add starttls option with support for mysql #264
get_certificate - add starttls option with support for mysql #264
Conversation
@markuman would you be able to try testing this PR locally? I had success with a MySQL server, but would like some more confirmation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice @Ajpantuso
works for me. tested against proxysql 2.1.1 and aws rds mariadb 10.4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! Works well :) I've just one small suggestion:
@Ajpantuso thanks a lot for implementing this! |
SUMMARY
Adds a
starttls
option to allow users to retrieve certificates fromMySQL
servers.Fixes #262
ISSUE TYPE
COMPONENT NAME
plugins/modules/get_certificate.py
ADDITIONAL INFORMATION
MySQL
server.Reference links: