Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ec2_asg_instance_refresh and ec2_asg_instance_refresh_info modules #973

Merged

Conversation

mandar242
Copy link
Contributor

@mandar242 mandar242 commented Mar 10, 2022

SUMMARY

Reviving original PR that adds Autoscaling instance refresh API support as the author has yet not updated PR based on review feedback.

Issue: #135
PR being revived: #795

Fixes #135

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

ec2_asg_instance_refresh
ec2_asg_instance_refreshes_info

ADDITIONAL INFORMATION

More about the feature: https://aws.amazon.com/blogs/compute/introducing-instance-refresh-for-ec2-auto-scaling/

Boto3 documentation: https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/autoscaling.html#AutoScaling.Client.start_instance_refresh

@ansibullbot
Copy link

@ansibullbot ansibullbot added the WIP Work in progress label Mar 10, 2022
@mandar242
Copy link
Contributor Author

recheck

@mandar242 mandar242 requested a review from alinabuzachis March 18, 2022 21:59
plugins/modules/ec2_asg_instance_refresh_info.py Outdated Show resolved Hide resolved
plugins/modules/ec2_asg_instance_refresh_info.py Outdated Show resolved Hide resolved
plugins/modules/ec2_asg_instance_refresh.py Outdated Show resolved Hide resolved
plugins/modules/ec2_asg_instance_refresh.py Show resolved Hide resolved
plugins/modules/ec2_asg_instance_refresh.py Outdated Show resolved Hide resolved
@mandar242 mandar242 requested a review from jillr March 22, 2022 16:21
Copy link
Contributor

@jatorcasso jatorcasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some minor comments - LGTM otherwise

plugins/modules/ec2_asg_instance_refresh.py Show resolved Hide resolved
plugins/modules/ec2_asg_instance_refresh.py Outdated Show resolved Hide resolved
plugins/modules/ec2_asg_instance_refresh_info.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@jillr jillr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @mandar242!

@markuman markuman added backport-3 PR should be backported to the stable-3 branch mergeit Merge the PR (SoftwareFactory) labels Mar 24, 2022
@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 3015013 into ansible-collections:main Mar 24, 2022
@patchback
Copy link

patchback bot commented Mar 24, 2022

Backport to stable-3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-3/301501391aa56d8b36d427bc8f8f7e9a6f513eef/pr-973

Backported as #1014

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Mar 24, 2022
)

ec2_asg_instance_refresh and ec2_asg_instance_refresh_info modules

SUMMARY

Reviving original PR that adds Autoscaling instance refresh API support as the author has yet not updated PR based on review feedback.
Issue: #135
PR being revived: #795
Fixes #135

ISSUE TYPE

New Module Pull Request

COMPONENT NAME

ec2_asg_instance_refresh
ec2_asg_instance_refreshes_info
ADDITIONAL INFORMATION

More about the feature: https://aws.amazon.com/blogs/compute/introducing-instance-refresh-for-ec2-auto-scaling/
Boto3 documentation: https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/autoscaling.html#AutoScaling.Client.start_instance_refresh

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Mandar Kulkarni <[email protected]>
Reviewed-by: Mark Woolley <[email protected]>
Reviewed-by: Jill R <None>
Reviewed-by: Joseph Torcasso <None>
(cherry picked from commit 3015013)
@mandar242 mandar242 deleted the ec2_asg_refresh branch March 24, 2022 17:43
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Mar 24, 2022
) (#1014)

[PR #973/30150139 backport][stable-3] ec2_asg_instance_refresh and ec2_asg_instance_refresh_info modules

This is a backport of PR #973 as merged into main (3015013).
SUMMARY

Reviving original PR that adds Autoscaling instance refresh API support as the author has yet not updated PR based on review feedback.
Issue: #135
PR being revived: #795
Fixes #135

ISSUE TYPE


New Module Pull Request

COMPONENT NAME

ec2_asg_instance_refresh
ec2_asg_instance_refreshes_info
ADDITIONAL INFORMATION



More about the feature: https://aws.amazon.com/blogs/compute/introducing-instance-refresh-for-ec2-auto-scaling/
Boto3 documentation: https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/autoscaling.html#AutoScaling.Client.start_instance_refresh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3 PR should be backported to the stable-3 branch community_review has_issue integration tests/integration mergeit Merge the PR (SoftwareFactory) module module new_module New module new_plugin New plugin plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autoscaling instance refresh API support
8 participants