Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoscaling instance refresh API support #135

Closed
gugu opened this issue Jul 11, 2020 · 4 comments · Fixed by #973
Closed

Autoscaling instance refresh API support #135

gugu opened this issue Jul 11, 2020 · 4 comments · Fixed by #973
Labels
affects_2.10 feature This issue/PR relates to a feature request has_pr module module plugins plugin (any type) waiting_on_contributor Needs help. Feel free to engage to get things unblocked

Comments

@gugu
Copy link

gugu commented Jul 11, 2020

SUMMARY

AWS recently introduced "Instance refresh" feature in ASG. Using it is preferred way to update launch configuration in ASG

ISSUE TYPE
  • Feature Idea
COMPONENT NAME

ec2_asg

ADDITIONAL INFORMATION

Deploying ASG from the client depends on internet connectivity and is not transactional. In the middle of deployment of ASG it can fail leaving ASG in unpredicted state. Using AWS infrastructure will add more stability in deployment (and probably will make it faster)

More about the feature: https://aws.amazon.com/blogs/compute/introducing-instance-refresh-for-ec2-auto-scaling/

Boto3 documentation: https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/autoscaling.html#AutoScaling.Client.start_instance_refresh

- commutiny.aws.ec2_asg_instance_refresh:
    name: some-backend
@ansibullbot
Copy link

Files identified in the description:

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibullbot
Copy link

@ansibullbot ansibullbot added affects_2.10 feature This issue/PR relates to a feature request module module needs_triage labels Aug 19, 2020
@ansibullbot ansibullbot added the plugins plugin (any type) label Aug 27, 2020
@goneri goneri added waiting_on_contributor Needs help. Feel free to engage to get things unblocked and removed needs_triage labels Feb 10, 2021
@danquixote
Copy link

Hello @goneri et al. I've submitted a PR here: #425

@ansibullbot
Copy link

softwarefactory-project-zuul bot pushed a commit that referenced this issue Mar 24, 2022
)

ec2_asg_instance_refresh and ec2_asg_instance_refresh_info modules

SUMMARY

Reviving original PR that adds Autoscaling instance refresh API support as the author has yet not updated PR based on review feedback.
Issue: #135
PR being revived: #795
Fixes #135

ISSUE TYPE


New Module Pull Request

COMPONENT NAME

ec2_asg_instance_refresh
ec2_asg_instance_refreshes_info
ADDITIONAL INFORMATION



More about the feature: https://aws.amazon.com/blogs/compute/introducing-instance-refresh-for-ec2-auto-scaling/
Boto3 documentation: https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/autoscaling.html#AutoScaling.Client.start_instance_refresh

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Mandar Kulkarni <[email protected]>
Reviewed-by: Mark Woolley <[email protected]>
Reviewed-by: Jill R <None>
Reviewed-by: Joseph Torcasso <None>
patchback bot pushed a commit that referenced this issue Mar 24, 2022
)

ec2_asg_instance_refresh and ec2_asg_instance_refresh_info modules

SUMMARY

Reviving original PR that adds Autoscaling instance refresh API support as the author has yet not updated PR based on review feedback.
Issue: #135
PR being revived: #795
Fixes #135

ISSUE TYPE

New Module Pull Request

COMPONENT NAME

ec2_asg_instance_refresh
ec2_asg_instance_refreshes_info
ADDITIONAL INFORMATION

More about the feature: https://aws.amazon.com/blogs/compute/introducing-instance-refresh-for-ec2-auto-scaling/
Boto3 documentation: https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/autoscaling.html#AutoScaling.Client.start_instance_refresh

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Mandar Kulkarni <[email protected]>
Reviewed-by: Mark Woolley <[email protected]>
Reviewed-by: Jill R <None>
Reviewed-by: Joseph Torcasso <None>
(cherry picked from commit 3015013)
softwarefactory-project-zuul bot pushed a commit that referenced this issue Mar 24, 2022
) (#1014)

[PR #973/30150139 backport][stable-3] ec2_asg_instance_refresh and ec2_asg_instance_refresh_info modules

This is a backport of PR #973 as merged into main (3015013).
SUMMARY

Reviving original PR that adds Autoscaling instance refresh API support as the author has yet not updated PR based on review feedback.
Issue: #135
PR being revived: #795
Fixes #135

ISSUE TYPE


New Module Pull Request

COMPONENT NAME

ec2_asg_instance_refresh
ec2_asg_instance_refreshes_info
ADDITIONAL INFORMATION



More about the feature: https://aws.amazon.com/blogs/compute/introducing-instance-refresh-for-ec2-auto-scaling/
Boto3 documentation: https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/autoscaling.html#AutoScaling.Client.start_instance_refresh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects_2.10 feature This issue/PR relates to a feature request has_pr module module plugins plugin (any type) waiting_on_contributor Needs help. Feel free to engage to get things unblocked
Projects
None yet
5 participants