[PR #913/55962ff2 backport][stable-3] Add deregistration_connection_termination to elb_target_group #926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
Add deregistration_connection_termination to elb_target_group SUMMARY Adding support for the deregistration_connection_termination param in the elb_target_group module. Along with this I've enabled and fixed up the integration tests. ISSUE TYPE Feature Pull Request COMPONENT NAME elb_target_group ADDITIONAL INFORMATION The API param is deregistration_delay.connection_termination.enabled https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/elbv2.html#ElasticLoadBalancingv2.Client.describe_target_group_attributes Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None> (cherry picked from commit 55962ff)
|
Build succeeded (third-party-check pipeline).
|
|
Build succeeded.
|
ansibullbot
added
community_review
feature
|
Build succeeded (gate pipeline).
|
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-3/55962ff21023ffdc6ecc1f985503c63852b3b19b/pr-913
branch
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…nsible-collections#926) ec2_vpc_route_table: Add support for Route entry for Carrier Gateway SUMMARY Add support for VPC Carrear Gateways entry on route table. ISSUE TYPE Feature Pull Request COMPONENT NAME module/ec2_vpc_route_table ADDITIONAL INFORMATION Support Carrier Gateway route on Route Table module using the same strategy of Nat GW, discovering the prefix of resource name cagw-. Not directly related, but testing in the same solution the cagw modules: ansible-collections#1353 ec2_carrier_gateway ec2_carrier_gateway_info Reviewed-by: Mark Chappell Reviewed-by: Marco Braga
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #913 as merged into main (55962ff).
SUMMARY
Adding support for the
deregistration_connection_terminationparam in theelb_target_groupmodule.Along with this I've enabled and fixed up the integration tests.
ISSUE TYPE
COMPONENT NAME
elb_target_group
ADDITIONAL INFORMATION
The API param is
deregistration_delay.connection_termination.enabledhttps://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/elbv2.html#ElasticLoadBalancingv2.Client.describe_target_group_attributes