Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module/vpc-cagw): Add Carrier Gateway modules #1353

Merged

Conversation

mtulio
Copy link
Contributor

@mtulio mtulio commented Jul 13, 2022

SUMMARY

New modules to manage VPC Carrear Gateways.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

modules (new):

  • ec2_carrier_gateway
  • ec2_carrier_gateway_info
ADDITIONAL INFORMATION
$ ansible localhost -m ec2_vpc_cagw_info
localhost | SUCCESS => {
    "carrier_gateways": [
        {
            "carrier_gateway_id": "cagw-037df45cae5362d59",
            "tags": {
                "Name": "test1-54dsl-vpc-cagw"
            },
            "vpc_id": "vpc-069cabb60c7e7fc6d"
        }
    ],
    "changed": false
}

$ ansible localhost -m ec2_carrier_gateway -a "state=absent vpc_id=vpc-069cabb60c7e7fc6d carrier_gateway_id=cagw-037df45cae5362d59"
localhost | CHANGED => {
    "changed": true
}


$ ansible localhost -m ec2_carrier_gateway_info
localhost | SUCCESS => {
    "carrier_gateways": [],
    "changed": false
}


$ ansible localhost -m ec2_carrier_gateway-a "vpc_id=vpc-069cabb60c7e7fc6d"
localhost | CHANGED => {
    "carrier_gateway_id": "cagw-095f998ebdcb5ef86",
    "changed": true,
    "tags": {},
    "vpc_id": "vpc-069cabb60c7e7fc6d"
}
$ ansible localhost -m ec2_carrier_gateway_info
localhost | SUCCESS => {
    "carrier_gateways": [
        {
            "carrier_gateway_id": "cagw-095f998ebdcb5ef86",
            "tags": {},
            "vpc_id": "vpc-069cabb60c7e7fc6d"
        }
    ],
    "changed": false
}

@mtulio mtulio force-pushed the feat-mod-vpc_cagw branch from 04a34a4 to d1e5e95 Compare July 13, 2022 04:50
@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review module module needs_triage new_contributor Help guide this first time contributor new_module New module new_plugin New plugin plugins plugin (any type) labels Jul 13, 2022
@github-actions
Copy link

github-actions bot commented Jul 13, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

✔️ ansible-galaxy-importer SUCCESS in 4m 03s
✔️ build-ansible-collection SUCCESS in 5m 09s
ansible-test-sanity-docker-devel FAILURE in 11m 03s (non-voting)
ansible-test-sanity-docker-milestone FAILURE in 10m 40s
ansible-test-sanity-docker-stable-2.12 FAILURE in 8m 59s
ansible-test-sanity-docker-stable-2.13 FAILURE in 12m 52s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 09s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 56s
✔️ ansible-test-splitter SUCCESS in 2m 28s
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mtulio,

Thanks for this work, it looks like a really good start. Most of my comments are stylistic niggles.

It looks like you've copied the framework from an existing module (which is fine) however you've pulled in some cruft which we probably want to avoid. We're slowly cleaning things up, so please understand that we might ask you to change things that you copied from other modules.

For net-new modules we generally require integration tests. These integration tests are just Ansible playbooks and can be found in tests/integration/targets/ the ec2_vpc_vgw tests are probably a good example to start with. Just copy them over to tests/integration/targets/<module_name> and update the aliases file to include the _info module.

I suspect it'll take a little while to get the tests to work in CI due to the need to enable a Wavelength AZ (which has other side effects), so I'd suggest adding unsupported to the aliases file, which means they can be run manually outside of the main CI, but we need to do some work to get them running in CI.

We have some more info about this in our dev guidelines:
https://github.com/ansible-collections/amazon.aws/blob/main/docs/docsite/rst/dev_guidelines.rst#integration-tests-for-aws-modules

plugins/modules/ec2_vpc_cagw.py Outdated Show resolved Hide resolved
plugins/modules/ec2_vpc_cagw.py Outdated Show resolved Hide resolved
plugins/modules/ec2_vpc_cagw.py Outdated Show resolved Hide resolved
plugins/modules/ec2_vpc_cagw.py Outdated Show resolved Hide resolved
plugins/modules/ec2_vpc_cagw.py Outdated Show resolved Hide resolved
plugins/modules/ec2_vpc_cagw_info.py Outdated Show resolved Hide resolved
plugins/modules/ec2_vpc_cagw_info.py Outdated Show resolved Hide resolved
plugins/modules/ec2_vpc_cagw_info.py Outdated Show resolved Hide resolved
plugins/modules/ec2_vpc_cagw_info.py Outdated Show resolved Hide resolved
plugins/modules/ec2_vpc_cagw.py Outdated Show resolved Hide resolved
@mtulio
Copy link
Contributor Author

mtulio commented Jul 13, 2022

Hi @tremble ,

Thanks for your quick review and feedback!

It looks like you've copied the framework from an existing module (which is fine) however you've pulled in some cruft which we probably want to avoid. We're slowly cleaning things up, so please understand that we might ask you to change things that you copied from other modules.

Yes, those plugins were based on the Internet Gateway plugins (amazon.aws.ec2_vpc_igw*), which is similar Carrier Gateways, but the module is also quite old. I am also quite new in ansible module development, thanks for your suggestions and feel free to request any change, even through it is to refact based on newer modules. :)

For net-new modules we generally require integration tests. These integration tests are just Ansible playbooks and can be found in tests/integration/targets/ the ec2_vpc_vgw tests are probably a good example to start with. Just copy them over to tests/integration/targets/<module_name> and update the aliases file to include the _info module.

Perfect, I will work on it.

I suspect it'll take a little while to get the tests to work in CI due to the need to enable a Wavelength AZ (which has other side effects), so I'd suggest adding unsupported to the aliases file, which means they can be run manually outside of the main CI, but we need to do some work to get them running in CI.

We have some more info about this in our dev guidelines: https://github.com/ansible-collections/amazon.aws/blob/main/docs/docsite/rst/dev_guidelines.rst#integration-tests-for-aws-modules

ACK. Let me write the tests and see if we can get more insights about it, but having a better handler for the exception when there are no Wavelength zone group enabled it seems to be something nice to have on the module.

@tremble
Copy link
Contributor

tremble commented Jul 13, 2022

A better handler for the exception when there are no Wavelength zone group enabled it seems to be something nice to have on the module.

We have two helpers "is_boto3_error_code" and "is_boto3_error_message" which will probably assist here:

try:
  client.create_carrier_gateway(...)
except is_boto3_error_message("You must be opted into a wavelength zone to create a carrier gateway.") as e:
  module.fail_json(msg="You must be opted into a wavelength zone to create a carrier gateway")

Similarly:

try:
  client.create_carrier_gateway(...)
except is_boto3_error_code("UnsupportedOperation") as e:
  module.fail_json_aws(e, msg="Creating a Carrier Gateway is not supported with your current configuration.")

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

✔️ ansible-galaxy-importer SUCCESS in 4m 28s
✔️ build-ansible-collection SUCCESS in 5m 06s
ansible-test-sanity-docker-devel FAILURE in 9m 01s (non-voting)
ansible-test-sanity-docker-milestone FAILURE in 10m 49s
ansible-test-sanity-docker-stable-2.12 FAILURE in 10m 17s
ansible-test-sanity-docker-stable-2.13 FAILURE in 10m 18s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 59s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 05s
✔️ ansible-test-splitter SUCCESS in 3m 32s
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@ansibullbot ansibullbot added integration tests/integration tests tests labels Jul 14, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

✔️ ansible-galaxy-importer SUCCESS in 4m 00s
✔️ build-ansible-collection SUCCESS in 5m 12s
ansible-test-sanity-docker-devel FAILURE in 12m 49s (non-voting)
ansible-test-sanity-docker-milestone FAILURE in 11m 42s
ansible-test-sanity-docker-stable-2.12 FAILURE in 12m 42s
ansible-test-sanity-docker-stable-2.13 FAILURE in 10m 50s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 19s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 39s
✔️ ansible-test-splitter SUCCESS in 2m 26s
✔️ integration-community.aws-1 SUCCESS in 6m 18s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

✔️ ansible-galaxy-importer SUCCESS in 4m 15s
✔️ build-ansible-collection SUCCESS in 5m 12s
ansible-test-sanity-docker-devel FAILURE in 10m 16s (non-voting)
ansible-test-sanity-docker-milestone FAILURE in 9m 24s
ansible-test-sanity-docker-stable-2.12 FAILURE in 10m 27s
ansible-test-sanity-docker-stable-2.13 FAILURE in 9m 47s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 5m 45s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 5m 22s
✔️ ansible-test-splitter SUCCESS in 2m 29s
✔️ integration-community.aws-1 SUCCESS in 5m 37s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

✔️ ansible-galaxy-importer SUCCESS in 3m 33s
✔️ build-ansible-collection SUCCESS in 4m 51s
ansible-test-sanity-docker-devel FAILURE in 10m 13s (non-voting)
ansible-test-sanity-docker-milestone FAILURE in 9m 30s
ansible-test-sanity-docker-stable-2.12 FAILURE in 7m 11s
ansible-test-sanity-docker-stable-2.13 FAILURE in 7m 42s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 7m 35s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 5m 55s
✔️ ansible-test-splitter SUCCESS in 2m 32s
✔️ integration-community.aws-1 SUCCESS in 5m 12s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

✔️ ansible-galaxy-importer SUCCESS in 4m 03s
✔️ build-ansible-collection SUCCESS in 5m 10s
ansible-test-sanity-docker-devel FAILURE in 7m 34s (non-voting)
ansible-test-sanity-docker-milestone FAILURE in 7m 26s
ansible-test-sanity-docker-stable-2.12 FAILURE in 8m 39s
ansible-test-sanity-docker-stable-2.13 FAILURE in 8m 27s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 31s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 5m 32s
✔️ ansible-test-splitter SUCCESS in 2m 29s
✔️ integration-community.aws-1 SUCCESS in 5m 06s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@mtulio mtulio marked this pull request as ready for review July 29, 2022 15:26
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 3m 31s
✔️ build-ansible-collection SUCCESS in 5m 05s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 49s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 10s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 57s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 46s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 5m 57s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 10s
✔️ ansible-test-splitter SUCCESS in 2m 32s
✔️ integration-community.aws-1 SUCCESS in 5m 27s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@ansibullbot ansibullbot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed community_review needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Jul 29, 2022
@tremble tremble added this to the 6.0.0 milestone Feb 24, 2023
@markuman
Copy link
Member

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/c15c9ff6e2f04c388ed16fd87f8ad44a

✔️ ansible-galaxy-importer SUCCESS in 4m 26s
✔️ build-ansible-collection SUCCESS in 12m 43s
ansible-test-sanity-docker-devel FAILURE in 11m 25s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 15s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 35s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 11m 28s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 11m 06s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 40s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 7m 16s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 5m 41s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 9m 17s
✔️ ansible-test-changelog SUCCESS in 4m 36s
✔️ ansible-test-splitter SUCCESS in 4m 48s
✔️ integration-community.aws-1 SUCCESS in 7m 07s
Skipped 21 jobs

@markuman
Copy link
Member

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/8504e34661e24605a415b703f8f7394d

✔️ ansible-galaxy-importer SUCCESS in 6m 05s
✔️ build-ansible-collection SUCCESS in 12m 45s
ansible-test-sanity-docker-devel FAILURE in 13m 31s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 59s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 14m 39s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 13m 18s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 13m 27s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 9m 42s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 9m 22s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 9m 07s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 6m 27s
✔️ ansible-test-changelog SUCCESS in 4m 17s
✔️ ansible-test-splitter SUCCESS in 4m 43s
✔️ integration-community.aws-1 SUCCESS in 8m 48s
Skipped 21 jobs

Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pushed some minor changes:

  • We're starting to move towards the "Black" formatting style
  • Some of the imports have been split up / moved around (we started having issues with circular dependencies)
  • The documentation fragments got renamed to better describe what they do.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/4ed67b8aefd64095a4a8fca7f1758d82

ansible-galaxy-importer FAILURE in 3m 55s
✔️ build-ansible-collection SUCCESS in 13m 11s
✔️ ansible-test-sanity-docker-devel SUCCESS in 13m 57s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 31s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 01s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 11m 56s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 10m 07s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 15s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 7m 13s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 00s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 6m 35s
✔️ ansible-test-changelog SUCCESS in 4m 24s
✔️ ansible-test-splitter SUCCESS in 4m 48s
✔️ integration-community.aws-1 SUCCESS in 5m 49s
Skipped 21 jobs

@tremble
Copy link
Contributor

tremble commented Mar 30, 2023

I'm sorry about the delay getting back to reviewing this, without the CGW stuff enabled in an account it's tough to properly test this, so I fear we'll have to trust that the modules work for now.

@tremble tremble force-pushed the feat-mod-vpc_cagw branch from e4571c2 to 3616de5 Compare March 30, 2023 08:42
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/bd586a85defb4fc08d8722a77d019c3d

ansible-galaxy-importer FAILURE in 3m 46s
✔️ build-ansible-collection SUCCESS in 12m 37s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 11s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 13s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 27s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 11m 23s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 11m 07s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 07s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 09s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 58s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 6m 34s
✔️ ansible-test-changelog SUCCESS in 4m 27s
✔️ ansible-test-splitter SUCCESS in 4m 42s
✔️ integration-community.aws-1 SUCCESS in 6m 08s
Skipped 21 jobs

@tremble tremble requested a review from markuman March 30, 2023 09:33
@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Mar 30, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

https://ansible.softwarefactory-project.io/zuul/buildset/5f8ba7ffc30244db9fe1706eea1f0396

ansible-galaxy-importer FAILURE in 5m 21s
✔️ build-ansible-collection SUCCESS in 12m 33s
✔️ ansible-test-sanity-docker-devel SUCCESS in 12m 08s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 57s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 12m 18s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 13m 16s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 13m 20s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 12s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 7m 11s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 7m 57s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 6m 20s
✔️ ansible-test-changelog SUCCESS in 4m 28s
✔️ ansible-test-splitter SUCCESS in 4m 44s
✔️ integration-community.aws-1 SUCCESS in 5m 50s
Skipped 21 jobs

@tremble
Copy link
Contributor

tremble commented Mar 30, 2023

regate

@softwarefactory-project-zuul
Copy link
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

https://ansible.softwarefactory-project.io/zuul/buildset/be5346774be24fd9b5c934b8ec24c5ed

ansible-galaxy-importer FAILURE in 3m 59s
✔️ build-ansible-collection SUCCESS in 12m 21s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 49s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 57s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 12m 31s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 13m 55s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 8m 40s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 09s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 7m 25s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 5m 32s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 7m 08s
✔️ ansible-test-changelog SUCCESS in 4m 30s
✔️ ansible-test-splitter SUCCESS in 4m 37s
✔️ integration-community.aws-1 SUCCESS in 5m 15s
Skipped 21 jobs

@tremble
Copy link
Contributor

tremble commented Mar 30, 2023

regate

@softwarefactory-project-zuul
Copy link
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

https://ansible.softwarefactory-project.io/zuul/buildset/f20a4209e724498182cef67421c66bad

ansible-galaxy-importer FAILURE in 3m 55s
✔️ build-ansible-collection SUCCESS in 12m 22s
✔️ ansible-test-sanity-docker-devel SUCCESS in 11m 27s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 06s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 26s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 11s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 11m 24s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 20s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 16s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 01s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 6m 48s
✔️ ansible-test-changelog SUCCESS in 4m 26s
✔️ ansible-test-splitter SUCCESS in 4m 44s
✔️ integration-community.aws-1 SUCCESS in 6m 15s
Skipped 21 jobs

@tremble
Copy link
Contributor

tremble commented Mar 30, 2023

regate

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/718581ac90cc4f72813ad0f6e0e0f15f

✔️ ansible-galaxy-importer SUCCESS in 4m 35s
✔️ build-ansible-collection SUCCESS in 12m 39s
✔️ ansible-test-sanity-docker-devel SUCCESS in 11m 33s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 16s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 12m 22s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 12m 02s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 15m 16s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 8m 28s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 5m 43s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 10m 27s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 5m 45s
✔️ ansible-test-changelog SUCCESS in 4m 26s
✔️ ansible-test-splitter SUCCESS in 4m 39s
✔️ integration-community.aws-1 SUCCESS in 6m 03s
Skipped 21 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 7ef4a6c into ansible-collections:main Mar 30, 2023
@mtulio mtulio deleted the feat-mod-vpc_cagw branch March 30, 2023 19:13
softwarefactory-project-zuul bot pushed a commit to ansible-collections/amazon.aws that referenced this pull request Mar 31, 2023
…926)

ec2_vpc_route_table: Add support for Route entry for Carrier Gateway

SUMMARY
Add support for VPC Carrear Gateways entry on route table.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME

module/ec2_vpc_route_table

ADDITIONAL INFORMATION
Support Carrier Gateway route on Route Table module using the same strategy of  Nat GW, discovering the prefix of resource name cagw-.
Not directly related, but testing in the same solution the cagw modules: ansible-collections/community.aws#1353

ec2_carrier_gateway
ec2_carrier_gateway_info

Reviewed-by: Mark Chappell
Reviewed-by: Marco Braga
boutetnico pushed a commit to boutetnico/community.aws that referenced this pull request Apr 3, 2023
…ns#1353)

feat(module/vpc-cagw): Add Carrier Gateway modules

SUMMARY
New modules to manage VPC Carrear Gateways.
ISSUE TYPE

New Module Pull Request

COMPONENT NAME
modules (new):

ec2_carrier_gateway
ec2_carrier_gateway_info

ADDITIONAL INFORMATION
$ ansible localhost -m ec2_vpc_cagw_info
localhost | SUCCESS => {
    "carrier_gateways": [
        {
            "carrier_gateway_id": "cagw-037df45cae5362d59",
            "tags": {
                "Name": "test1-54dsl-vpc-cagw"
            },
            "vpc_id": "vpc-069cabb60c7e7fc6d"
        }
    ],
    "changed": false
}

$ ansible localhost -m ec2_carrier_gateway -a "state=absent vpc_id=vpc-069cabb60c7e7fc6d carrier_gateway_id=cagw-037df45cae5362d59"
localhost | CHANGED => {
    "changed": true
}


$ ansible localhost -m ec2_carrier_gateway_info
localhost | SUCCESS => {
    "carrier_gateways": [],
    "changed": false
}


$ ansible localhost -m ec2_carrier_gateway-a "vpc_id=vpc-069cabb60c7e7fc6d"
localhost | CHANGED => {
    "carrier_gateway_id": "cagw-095f998ebdcb5ef86",
    "changed": true,
    "tags": {},
    "vpc_id": "vpc-069cabb60c7e7fc6d"
}
$ ansible localhost -m ec2_carrier_gateway_info
localhost | SUCCESS => {
    "carrier_gateways": [
        {
            "carrier_gateway_id": "cagw-095f998ebdcb5ef86",
            "tags": {},
            "vpc_id": "vpc-069cabb60c7e7fc6d"
        }
    ],
    "changed": false
}

Reviewed-by: Mark Chappell
Reviewed-by: Marco Braga
Reviewed-by: Markus Bergholz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review integration tests/integration mergeit Merge the PR (SoftwareFactory) module module new_contributor Help guide this first time contributor new_module New module new_plugin New plugin plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants