Remove unsed imports #892
Closed
Remove unsed imports #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded.
|
markuman
approved these changes
Jan 27, 2022
|
recheck |
ansibullbot
added
community_review
feature
|
Build succeeded (gate pipeline).
|
|
Pull request merge failed: Required status check "ansible/gate" is failing. |
|
@tremble the ansible/gate status from the old dashboard.zuul.ansible.com is now disabled and we cannot rerun it. I think it will be hard to cleam up the CI status from this PR. May I ask you to close this PR and push a new one? |
|
Build succeeded.
|
Merged
|
I initially tried recreating this one as a fresh PR from the same branch. Unfortunately, it looks like GitHub was being "clever", spotted the commits were the same and copied the pipelines over. #896 looks to have been more successful (fresh branch, fresh commit). |
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Jan 30, 2022
Cleanup unused imports (#852 / #892) Let's try once more... SUMMARY My local tests are flagging that we've picked up some unused imports again. ISSUE TYPE Feature Pull Request COMPONENT NAME aws_glue_job cloudfront_info rds_option_group_info ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None>
patchback bot
pushed a commit
that referenced
this pull request
Jan 30, 2022
Cleanup unused imports (#852 / #892) Let's try once more... SUMMARY My local tests are flagging that we've picked up some unused imports again. ISSUE TYPE Feature Pull Request COMPONENT NAME aws_glue_job cloudfront_info rds_option_group_info ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None> (cherry picked from commit 017081c)
tremble
added a commit
that referenced
this pull request
Jan 30, 2022
Cleanup unused imports (#852 / #892) Let's try once more... SUMMARY My local tests are flagging that we've picked up some unused imports again. ISSUE TYPE Feature Pull Request COMPONENT NAME aws_glue_job cloudfront_info rds_option_group_info ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None> (cherry picked from commit 017081c) Co-authored-by: Mark Chappell <[email protected]>
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…collections#892) Bump from 5.0.0 to 5.0.0-dev0 in case of accidental release SUMMARY Bump from 5.0.0 to 5.0.0-dev0 in case of accidental release ISSUE TYPE Feature Pull Request COMPONENT NAME galaxy.yml ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
Cleanup unused imports (ansible-collections#852 / ansible-collections#892) Let's try once more... SUMMARY My local tests are flagging that we've picked up some unused imports again. ISSUE TYPE Feature Pull Request COMPONENT NAME aws_glue_job cloudfront_info rds_option_group_info ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@017081c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a fresh PR because the broken ansible/gate run from the old CI was blocking gating.
Was approved as #852 - no changes
SUMMARY
My local tests are flagging that we've picked up some unused imports again.
ISSUE TYPE
COMPONENT NAME
aws_glue_job
cloudfront_info
rds_option_group_info
ADDITIONAL INFORMATION