Remove unsed imports #852
Closed
Remove unsed imports #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded.
|
alinabuzachis
approved these changes
Jan 7, 2022
markuman
approved these changes
Jan 7, 2022
![ansible-zuul[bot]](https://avatars.githubusercontent.com/in/27800?s=60&v=4){kind=small}
|
|
cc @goneri
|
|
@alinabuzachis Thanks, I take a look. |
|
@alinabuzachis, The disk space problem comes from pypa/pip#8713, pip download a gazillon of copy of awscli. The files end up in /tmp. /tmp is a RAM disk and we don't have unlimited freeze space. At some point we hit the |
|
@goneri pip sometimes handles boto3/botocore == X.Y.Z rather badly, it downloads every version of awscli (starting with the newest) until it finds one which matches. There used to be an awscli=A.B.C which should match the boto3/botocore requirement. |
|
Note: In this case, pip don't use the containtant file tests/unit/constraints.txt. |
goneri
added a commit
to goneri/ansible-zuul-jobs
that referenced
this pull request
Jan 10, 2022
/tmp is ramdisk with limited amount of space. We use `TMPDIR` to ensure `pip` use `/var/tmp/ansible-test-pip` as an alternative. This is what Fedora documentation advices. See: ansible-collections/community.aws#852
|
recheck |
|
This change depends on a change with an invalid configuration. |
|
recheck |
|
This change depends on a change with an invalid configuration. |
ansible-zuul bot
pushed a commit
to ansible/ansible-zuul-jobs
that referenced
this pull request
Jan 10, 2022
ansible-test: get pip tp use /var/tmp as tmp dir /tmp is ramdisk with limited amount of space. We use TMPDIR to ensure pip use /var/tmp/ansible-test-pip as an alternative. This is what Fedora documentation advices. See: ansible-collections/community.aws#852 Reviewed-by: None <None>
|
This change depends on a change that failed to merge. |
|
recheck |
|
recheck |
|
Build succeeded.
|
tremble
added
mergeit
|
Build succeeded (gate pipeline).
|
|
Pull request merge failed: Required status check "ansible/gate" is failing. |
|
recheck |
|
Build succeeded.
|
|
Build succeeded (gate pipeline).
|
|
Pull request merge failed: Required status check "ansible/gate" is failing. |
|
recheck |
|
Build succeeded.
|
|
Build succeeded (gate pipeline).
|
|
Pull request merge failed: Required status check "ansible/gate" is failing. |
This was referenced Jan 27, 2022
Closed
Merged
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Jan 30, 2022
Cleanup unused imports (#852 / #892) Let's try once more... SUMMARY My local tests are flagging that we've picked up some unused imports again. ISSUE TYPE Feature Pull Request COMPONENT NAME aws_glue_job cloudfront_info rds_option_group_info ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None>
patchback bot
pushed a commit
that referenced
this pull request
Jan 30, 2022
Cleanup unused imports (#852 / #892) Let's try once more... SUMMARY My local tests are flagging that we've picked up some unused imports again. ISSUE TYPE Feature Pull Request COMPONENT NAME aws_glue_job cloudfront_info rds_option_group_info ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None> (cherry picked from commit 017081c)
tremble
added a commit
that referenced
this pull request
Jan 30, 2022
Cleanup unused imports (#852 / #892) Let's try once more... SUMMARY My local tests are flagging that we've picked up some unused imports again. ISSUE TYPE Feature Pull Request COMPONENT NAME aws_glue_job cloudfront_info rds_option_group_info ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None> (cherry picked from commit 017081c) Co-authored-by: Mark Chappell <[email protected]>
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…ctions#852) ec2_instance: metadata_options version_added increased SUMMARY After CI troubles in the past, we've forget to backport this feature. incr from 3.2.0 to 3.3.0 ansible-collections#763 failed backport 3 PR for 3.2.0 release ansible-collections#721 initial implementation for 3.2.0 ansible-collections#715 therefore no changelog fragment is necessary. ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_instance ADDITIONAL INFORMATION Reviewed-by: Jill R <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Chappell <None>
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
Cleanup unused imports (ansible-collections#852 / ansible-collections#892) Let's try once more... SUMMARY My local tests are flagging that we've picked up some unused imports again. ISSUE TYPE Feature Pull Request COMPONENT NAME aws_glue_job cloudfront_info rds_option_group_info ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@017081c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends-On: ansible/ansible-zuul-jobs#1285
Depends-On: ansible/ansible-zuul-jobs#1286
Depends-On: ansible/ansible-zuul-jobs#1287
SUMMARY
My local tests are flagging that we've picked up some unused imports again.
ISSUE TYPE
COMPONENT NAME
aws_glue_job
cloudfront_info
rds_option_group_info
ADDITIONAL INFORMATION