-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for community.aws release 3.0.0 #848
Prepare for community.aws release 3.0.0 #848
Conversation
Build failed.
|
recheck |
Build failed.
|
recheck |
Build failed.
|
recheck |
Build failed.
|
recheck |
Build succeeded.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess you also have to update the amazon.aws version here https://github.com/ansible-collections/community.aws/blob/main/tests/requirements.yml#L2
I guess docs update is missing. Did you generate the docs using collection_prep
repo?
Build failed.
|
recheck |
Build succeeded.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about the delayed response. Mostly looks good ec2_elb was deprecated and should probably go away.
Build succeeded.
|
Build failed.
|
recheck |
Build succeeded.
|
recheck |
Build succeeded.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The gating process is stalling... |
@markuman I throw it there. Could it be because there seems to be Changes requested? Have you tried to dismiss this? |
I'll try |
…ansible-collections#848) ec2_vpc_net - Deprecate purge_tags=False and support management by ID Depends-On: ansible-collections#844 SUMMARY Deprecate purge_tags=False and support managing VPCs by ID which lets us change tags ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_vpc_net ADDITIONAL INFORMATION Integration test for management by ID Reviewed-by: Markus Bergholz <[email protected]>
SUMMARY
next major release
ISSUE TYPE
COMPONENT NAME
everything