Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for community.aws release 3.0.0 #848

Merged
merged 6 commits into from
Jan 12, 2022
Merged

Prepare for community.aws release 3.0.0 #848

merged 6 commits into from
Jan 12, 2022

Conversation

markuman
Copy link
Member

@markuman markuman commented Jan 6, 2022

SUMMARY

next major release

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

everything

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@markuman
Copy link
Member Author

markuman commented Jan 6, 2022

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@markuman
Copy link
Member Author

markuman commented Jan 6, 2022

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@markuman
Copy link
Member Author

markuman commented Jan 6, 2022

recheck

@markuman
Copy link
Member Author

markuman commented Jan 6, 2022

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

Copy link
Contributor

@alinabuzachis alinabuzachis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you also have to update the amazon.aws version here https://github.com/ansible-collections/community.aws/blob/main/tests/requirements.yml#L2

I guess docs update is missing. Did you generate the docs using collection_prep repo?

galaxy.yml Show resolved Hide resolved
@markuman markuman requested a review from alinabuzachis January 7, 2022 09:40
@markuman
Copy link
Member Author

markuman commented Jan 7, 2022

recheck

tremble
tremble previously requested changes Jan 7, 2022
Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the delayed response. Mostly looks good ec2_elb was deprecated and should probably go away.

meta/runtime.yml Show resolved Hide resolved
@markuman markuman requested a review from tremble January 7, 2022 18:07
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@markuman
Copy link
Member Author

markuman commented Jan 8, 2022

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@markuman
Copy link
Member Author

markuman commented Jan 9, 2022

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@markuman markuman requested a review from alinabuzachis January 9, 2022 10:47
@markuman markuman added the gate label Jan 11, 2022
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@markuman markuman added gate and removed gate labels Jan 11, 2022
@markuman
Copy link
Member Author

The gating process is stalling...
cc @goneri

@alinabuzachis
Copy link
Contributor

alinabuzachis commented Jan 12, 2022

@markuman I throw it there. Could it be because there seems to be Changes requested? Have you tried to dismiss this?

@markuman markuman dismissed tremble’s stale review January 12, 2022 11:03

try it and see

@markuman
Copy link
Member Author

@markuman I throw it there. Could it be because there seems to be Changes requested? Have you tried to dismiss this?

I'll try

@markuman markuman added gate and removed gate labels Jan 12, 2022
@ansible-zuul ansible-zuul bot merged commit ca5ef92 into ansible-collections:main Jan 12, 2022
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
…ansible-collections#848)

ec2_vpc_net - Deprecate purge_tags=False and support management by ID

Depends-On: ansible-collections#844
SUMMARY
Deprecate purge_tags=False and support managing VPCs by ID which lets us change tags
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
ec2_vpc_net
ADDITIONAL INFORMATION

 Integration test for management by ID

Reviewed-by: Markus Bergholz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants