increase length clientRequestToken for 33char min #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS Updated this parameter to require a minimum of 33 chars. With the old string of 'ansible-create-%s', anyone who uses this module to create a cluster with a name < 18 characters will encounter an InvalidParameterError
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…s#844) Tagging - add docs fragment and update guidelines SUMMARY As discussed in the last working group meeting. Adding a doc fragment and updating the guidelines to make purge_tags=True the preferred behaviour. ISSUE TYPE Docs Pull Request COMPONENT NAME docs/docsite/rst/dev_guidelines.rst plugins/doc_fragments/tags.py ADDITIONAL INFORMATION Reviewed-by: Felix Fontein <[email protected]> Reviewed-by: Mark Chappell <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Sandra McCann <[email protected]>
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…ons#845) Tagging - switch simplest cases to use doc fragment Depends-On: ansible-collections#844 SUMMARY Switch the simplest tagging cases over to using the docs fragment ISSUE TYPE Docs Pull Request Feature Pull Request COMPONENT NAME plugins/modules/aws_s3.py plugins/modules/ec2_eni.py plugins/modules/ec2_group.py plugins/modules/ec2_vpc_dhcp_option.py plugins/modules/ec2_vpc_igw.py plugins/modules/ec2_vpc_nat_gateway.py plugins/modules/ec2_vpc_subnet.py plugins/modules/elb_classic_lb.py plugins/modules/s3_bucket.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…ansible-collections#848) ec2_vpc_net - Deprecate purge_tags=False and support management by ID Depends-On: ansible-collections#844 SUMMARY Deprecate purge_tags=False and support managing VPCs by ID which lets us change tags ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_vpc_net ADDITIONAL INFORMATION Integration test for management by ID Reviewed-by: Markus Bergholz <[email protected]>
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…#846) Tagging - deprecate defaults of purge_tags=False Depends-On: ansible-collections#844 SUMMARY The simple cases where we want to deprecate purge_tags=False ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/ec2_ami.py plugins/modules/ec2_key.py plugins/modules/ec2_vol.py plugins/modules/ec2_vpc_endpoint.py plugins/modules/ec2_vpc_route_table.py ADDITIONAL INFORMATION Reviewed-by: Gonéri Le Bouder <[email protected]>
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
ec2_instance - deprecate purge_tags=False Depends-On: ansible-collections#844 SUMMARY Deprecate purge_tags=False for ec2_instance ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/ec2_instance.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
tagging docs fragment - comment cleanup (C&P) SUMMARY When creating the docs fragment in ansible-collections#844 the comment above the fragments was left behind from the fragment I used as a base, tweak the comment. ISSUE TYPE Docs Pull Request COMPONENT NAME plugins/doc_fragments/tags.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the old string of 'ansible-create-%s', anyone who uses this module to create a cluster with a name < 18 characters will encounter an InvalidParameterError
SUMMARY
AWS Updated this parameter to require a minimum of 33 chars.
Unaware of existing issue for this, I encountered it today and couldnt find much online.
ISSUE TYPE
COMPONENT NAME
aws_eks_cluster.py module
ADDITIONAL INFORMATION
Without this fix, any cluster created using this module, with a cluster name < 18 characters, will encounter the following error:
"Couldn't create cluster <cluster_name>: An error occurred (InvalidParameterException) when calling the CreateCluster operation: The client request token parameter must be between 33 and 126 characters."