Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route53: fix diff mode when state: absent #802

Merged
merged 1 commit into from
Nov 12, 2021
Merged

Route53: fix diff mode when state: absent #802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/802-fix-diif-mode.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
bugfixes:
- route53 - fix diff mode when deleting records (https://github.com/ansible-collections/community.aws/pull/801).
2 changes: 1 addition & 1 deletion plugins/modules/route53.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -692,7 +692,7 @@ def main():
changed=True,
diff=dict(
before=formatted_aws,
after=formatted_record if command != 'delete' else {},
after=formatted_record if command_in != 'delete' else {},
resource_record_sets=rr_sets,
),
)
Expand Down
1 change: 1 addition & 0 deletions tests/integration/targets/route53/tasks/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,6 +386,7 @@
that:
- wc_a_record is not failed
- wc_a_record is changed
- wc_a_record.diff.after == {}

# Tests on zone two (private zone)
- name: Create A record using zone fqdn
Expand Down