Route53: fix diff mode when state: absent #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixfontein
approved these changes
Nov 12, 2021
![ansible-zuul[bot]](https://avatars.githubusercontent.com/in/27800?s=60&v=4){kind=small}
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
…et name (ansible-collections#802) Update s3 module_util validate_bucket_name to accept 3 character bucket name SUMMARY According to the S3 docs (https://docs.aws.amazon.com/AmazonS3/latest/userguide/bucketnamingrules.html), the minimum bucket name is 3 characters. The current validate_bucket_name function fails for any bucket name less than 4 characters. This PR updates the check and adds unit test cases for minimum length. ISSUE TYPE Bugfix Pull Request COMPONENT NAME s3 ADDITIONAL INFORMATION To reproduce, attempt to perform an action on a bucket with a 3 character name. Reviewed-by: Alina Buzachis <None> Reviewed-by: Gonéri Le Bouder <[email protected]>
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
Route53: fix diff mode when state: absent SUMMARY Fix diff mode when state: absend ISSUE TYPE Bugfix Pull Request COMPONENT NAME route53 Reviewed-by: Felix Fontein <None> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@2b01e9c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fix diff mode when
state: absendISSUE TYPE
COMPONENT NAME
route53