Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: don't test ancient boto3 versions #636

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions tests/integration/targets/cloudformation_stack_set/runme.sh
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
#!/usr/bin/env bash

set -eux

# Run full test suite
source virtualenv.sh
pip install 'botocore>1.10.26' boto3
ansible-playbook -i ../../inventory -v playbooks/full_test.yml "$@"
32 changes: 0 additions & 32 deletions tests/integration/targets/efs/playbooks/version_fail.yml

This file was deleted.

8 changes: 0 additions & 8 deletions tests/integration/targets/efs/runme.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,4 @@ set -eux

export ANSIBLE_ROLES_PATH=../

# Test graceful failure for older versions of botocore
source virtualenv.sh
pip install 'botocore<1.10.57' boto3
ansible-playbook -i ../../inventory -v playbooks/version_fail.yml "$@"

# Run full test suite
source virtualenv.sh
pip install 'botocore>=1.10.57' boto3
ansible-playbook -i ../../inventory -v playbooks/full_test.yml "$@"
Original file line number Diff line number Diff line change
Expand Up @@ -91,11 +91,6 @@
state: present
register: tg

# Run tests for graceful failure with an old version of botocore
- include_tasks: test_multiple_actions_fail.yml
vars:
ansible_python_interpreter: "{{ virtualenv_interpreter }}"

# Run main tests
- include_tasks: test_alb_bad_listener_options.yml
- include_tasks: test_alb_ip_address_type_options.yml
Expand Down
29 changes: 0 additions & 29 deletions tests/integration/targets/elb_application_lb/tasks/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,33 +8,4 @@
security_token: '{{ security_token | default(omit) }}'
region: '{{ aws_region }}'
block:

# Prepare a virtual environment for multiple_actions_fail.yml
- set_fact:
virtualenv: "{{ remote_tmp_dir }}/virtualenv"
virtualenv_command: "{{ ansible_python_interpreter }} -m virtualenv"

- set_fact:
virtualenv_interpreter: "{{ virtualenv }}/bin/python"

- pip:
name: virtualenv

- pip:
name:
- 'botocore<1.10.30'
- boto3
- boto
- coverage<5
- cryptography
virtualenv: "{{ virtualenv }}"
virtualenv_command: "{{ virtualenv_command }}"
virtualenv_site_packages: no

- include_tasks: full_test.yml

always:

- file:
path: "{{ virtualenv }}"
state: absent

This file was deleted.

41 changes: 0 additions & 41 deletions tests/integration/targets/elb_target/playbooks/version_fail.yml

This file was deleted.

7 changes: 0 additions & 7 deletions tests/integration/targets/elb_target/runme.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,5 @@

set -eux

# Test graceful failure for older versions of botocore
source virtualenv.sh
pip install 'botocore<=1.7.1' boto3
ansible-playbook -i ../../inventory -v playbooks/version_fail.yml "$@"

# Run full test suite
source virtualenv.sh
pip install 'botocore' 'boto3>=1.16.57'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

boto3 >= 1.13.0

boto3 1.16.57 is only around 6 months old...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I went to fast on this one.

ansible-playbook -i ../../inventory -v playbooks/full_test.yml "$@"