tests: don't test ancient boto3 versions #636
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
goneri
force-pushed
the
elb_target-test-use-2nd-venv_25725
branch
from
4c3ba25 to
0446072
Compare
goneri
changed the title
goneri
force-pushed
the
elb_target-test-use-2nd-venv_25725
branch
from
0446072 to
067f6f8
Compare
tremble
requested changes
Jul 13, 2021
|
recheck |
|
recheck |
5 similar comments
|
recheck |
|
recheck |
|
recheck |
|
recheck |
|
recheck |
goneri
force-pushed
the
elb_target-test-use-2nd-venv_25725
branch
from
067f6f8 to
4a98e59
Compare
goneri
changed the title
These tests were a source of problems and are pointless now we only support `boto3 >= 1.13.0` and `botocore >= 1.16.0`
goneri
force-pushed
the
elb_target-test-use-2nd-venv_25725
branch
from
4a98e59 to
512755c
Compare
tremble
reviewed
Jul 14, 2021
| # Run full test suite | ||
| source virtualenv.sh | ||
| pip install 'botocore' 'boto3>=1.16.57' |
There was a problem hiding this comment.
boto3 >= 1.13.0
boto3 1.16.57 is only around 6 months old...
There was a problem hiding this comment.
Oh, I went to fast on this one.
|
Made moot by #675 |
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
…tly (ansible-collections#636) Fix typo Reviewed-by: Mark Chappell <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Jill R <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
These tests were a source of problems and are pointless now we only
support
boto3 >= 1.13.0andbotocore >= 1.16.0ISSUE TYPE
COMPONENT NAME
tests