ECS service - add tag+propagate_tags upon creation. #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
community_review
feature
tremble
reviewed
Apr 15, 2021
|
Thanks for taking this PR over. Looks like you're falling foul of a linting issue: https://dashboard.zuul.ansible.com/t/ansible/build/254378a734334c62a889731fe8029290 |
tremble
reviewed
Apr 16, 2021
tamirhad
commented
Apr 18, 2021
There was a problem hiding this comment.
@tamirhad Thank you for working on this. I left you some comments. If you need any help don't hesitate to contact us on IRC #ansible-aws.
tamirhad
force-pushed
the
main
branch
2 times, most recently
from
4f5d277 to
a7119ff
Compare
|
@tamirhad can you resolve the conflict and rebase, so that we see where it failed nowadays? |
ansibullbot
added
needs_rebase
|
yes, ill try to find a time for that asap. |
tremble
force-pushed
the
main
branch
3 times, most recently
from
84f1bc4 to
8466fe1
Compare
ansibullbot
added
community_review
and removed
needs_rebase
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
…e Error comes from the API (ansible-collections#543) Remove reference to 'boto' from s3_bucket failure SUMMARY Remove reference to 'boto' from s3_bucket failure: it's not using boto. ISSUE TYPE Docs Pull Request COMPONENT NAME s3_bucket ADDITIONAL INFORMATION Reviewed-by: None <None>
|
Looking to revive this, so far I've only rebased. |
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
tremble
approved these changes
Jul 6, 2022
tremble
added
mergeit
Backport to stable-4: 💚 backport PR created✅ Backport PR branch: Backported as #1317 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jul 6, 2022
ECS service - add tag+propagate_tags upon creation. SUMMARY this PR is continuation of #242 this PR will enable the use of tags at creation time, in addition to propagate_tags. ISSUE TYPE Feature Pull Request COMPONENT NAME ecs_service ADDITIONAL INFORMATION this PR is continuation of #242 i cant contribute to his repo as i am not a maintainer so i created a new PR, if its not the right git flow please be gentle, its my first time :) Reviewed-by: Mark Chappell <None> Reviewed-by: None <None> Reviewed-by: Alina Buzachis <None> (cherry picked from commit e3c8302)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Jul 6, 2022
[PR #543/e3c8302c backport][stable-4] ECS service - add tag+propagate_tags upon creation. This is a backport of PR #543 as merged into main (e3c8302). SUMMARY this PR is continuation of #242 this PR will enable the use of tags at creation time, in addition to propagate_tags. ISSUE TYPE Feature Pull Request COMPONENT NAME ecs_service ADDITIONAL INFORMATION this PR is continuation of #242 i cant contribute to his repo as i am not a maintainer so i created a new PR, if its not the right git flow please be gentle, its my first time :) Reviewed-by: Mark Chappell <None>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
this PR is continuation of #242
this PR will enable the use of tags at creation time, in addition to propagate_tags.
ISSUE TYPE
COMPONENT NAME
ecs_service
ADDITIONAL INFORMATION
this PR is continuation of #242
i cant contribute to his repo as i am not a maintainer so i created a new PR, if its not the right git flow please be gentle, its my first time :)