[PR #543/e3c8302c backport][stable-4] ECS service - add tag+propagate_tags upon creation. #1317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
ECS service - add tag+propagate_tags upon creation. SUMMARY this PR is continuation of #242 this PR will enable the use of tags at creation time, in addition to propagate_tags. ISSUE TYPE Feature Pull Request COMPONENT NAME ecs_service ADDITIONAL INFORMATION this PR is continuation of #242 i cant contribute to his repo as i am not a maintainer so i created a new PR, if its not the right git flow please be gentle, its my first time :) Reviewed-by: Mark Chappell <None> Reviewed-by: None <None> Reviewed-by: Alina Buzachis <None> (cherry picked from commit e3c8302)
tremble
approved these changes
Jul 6, 2022
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
ansibullbot
added
community_review
feature
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-4/e3c8302c3d5357fd501bc0385dee32a5b8098d37/pr-543
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #543 as merged into main (e3c8302).
SUMMARY
this PR is continuation of #242
this PR will enable the use of tags at creation time, in addition to propagate_tags.
ISSUE TYPE
COMPONENT NAME
ecs_service
ADDITIONAL INFORMATION
this PR is continuation of #242
i cant contribute to his repo as i am not a maintainer so i created a new PR, if its not the right git flow please be gentle, its my first time :)