Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid per-test virtual environments where possible #467

Merged
merged 7 commits into from
Mar 10, 2021

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Mar 10, 2021

SUMMARY

Move the primary tests for various modules over to using the standard virtual environment:

  • ec2_launch_template
  • elb_application_lb
  • elb_target_info
ISSUE TYPE
  • Tests Pull Request
COMPONENT NAME

ec2_launch_template
elb_application_lb
elb_target_info

ADDITIONAL INFORMATION

#442 exposed that some test suites were running in their own custom virtual environment when they didn't need to. Move the non-version-dependent tests back to our standard environment

@ansibullbot
Copy link

@tremble tremble force-pushed the cleanup/botocore_versions branch 2 times, most recently from e2d979e to 9865d06 Compare March 10, 2021 13:56
@tremble tremble force-pushed the cleanup/botocore_versions branch from 9865d06 to 035796f Compare March 10, 2021 14:41
@ansibullbot ansibullbot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed community_review labels Mar 10, 2021
@tremble tremble requested a review from jillr March 10, 2021 19:01
@ansibullbot ansibullbot added community_review and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Mar 10, 2021
@jillr jillr merged commit 887d624 into ansible-collections:main Mar 10, 2021
danquixote pushed a commit to danquixote/community.aws that referenced this pull request May 16, 2021
…ns#467)

* Move ec2_launch_template to standard role-type test

* Run elb_application_lb in our standard environment

* Move elb_target_info to the standard role structure

* add remote_tmp_dir dependency to ec2_launch_template

* move test_multiple_actions_fail.yml inside full_test so we don't need to run the prep work twice

* Rename the ALBs: "my-alb" isn't helpful and resource prefix is likely to change on us

* Ensure ALBs are deleted if "failed" tests created something
@tremble tremble deleted the cleanup/botocore_versions branch June 29, 2021 12:57
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
…ns#467)

* Move ec2_launch_template to standard role-type test

* Run elb_application_lb in our standard environment

* Move elb_target_info to the standard role structure

* add remote_tmp_dir dependency to ec2_launch_template

* move test_multiple_actions_fail.yml inside full_test so we don't need to run the prep work twice

* Rename the ALBs: "my-alb" isn't helpful and resource prefix is likely to change on us

* Ensure ALBs are deleted if "failed" tests created something
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
…ns#467)

* Move ec2_launch_template to standard role-type test

* Run elb_application_lb in our standard environment

* Move elb_target_info to the standard role structure

* add remote_tmp_dir dependency to ec2_launch_template

* move test_multiple_actions_fail.yml inside full_test so we don't need to run the prep work twice

* Rename the ALBs: "my-alb" isn't helpful and resource prefix is likely to change on us

* Ensure ALBs are deleted if "failed" tests created something
danielcotton pushed a commit to danielcotton/community.aws that referenced this pull request Nov 23, 2021
…ns#467)

* Move ec2_launch_template to standard role-type test

* Run elb_application_lb in our standard environment

* Move elb_target_info to the standard role structure

* add remote_tmp_dir dependency to ec2_launch_template

* move test_multiple_actions_fail.yml inside full_test so we don't need to run the prep work twice

* Rename the ALBs: "my-alb" isn't helpful and resource prefix is likely to change on us

* Ensure ALBs are deleted if "failed" tests created something
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants