Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup ec2_vpc_route_table(_info) #442

Merged

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Feb 24, 2021

SUMMARY
  • Migrate ec2_vpc_route_table_info to boto3
  • Be more consistent with retry decorator
  • Cleanup docs
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ec2_vpc_route_table
ec2_vpc_route_table_info

ADDITIONAL INFORMATION

@jillr jillr self-assigned this Feb 24, 2021
@ansibullbot
Copy link

@ansibullbot ansibullbot added WIP Work in progress feature This issue/PR relates to a feature request integration tests/integration module module plugins plugin (any type) tests tests labels Feb 24, 2021
@tremble tremble force-pushed the stability/ec2_vpc_route_table branch from fb12fde to 668fd81 Compare February 25, 2021 14:37
@tremble tremble changed the title [WIP] Cleanup ec2_vpc_route_table(_info) Cleanup ec2_vpc_route_table(_info) Feb 25, 2021
@ansibullbot ansibullbot added community_review and removed WIP Work in progress labels Feb 25, 2021
@tremble tremble requested a review from jillr February 25, 2021 18:56
@tremble tremble requested a review from alinabuzachis March 8, 2021 13:18
@tremble tremble force-pushed the stability/ec2_vpc_route_table branch from 668fd81 to 032f209 Compare March 10, 2021 08:55
@tremble tremble requested a review from alinabuzachis March 10, 2021 10:16
@tremble
Copy link
Contributor Author

tremble commented Mar 10, 2021

Has approval and tests are passing. merging

@tremble tremble merged commit dfb20a3 into ansible-collections:main Mar 10, 2021
danquixote pushed a commit to danquixote/community.aws that referenced this pull request May 16, 2021
* Move ec2_vpc_route_table tests into group 4
* ec2_vpc_route_table - Use retries more consistently.
* ec2_vpc_route_table_info - boto3 migration
* changelog
* Add return value documentation
* catch WaiterError for cleaner error messages
@tremble tremble deleted the stability/ec2_vpc_route_table branch June 29, 2021 12:57
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 16, 2021
* Move ec2_vpc_route_table tests into group 4
* ec2_vpc_route_table - Use retries more consistently.
* ec2_vpc_route_table_info - boto3 migration
* changelog
* Add return value documentation
* catch WaiterError for cleaner error messages

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@dfb20a3
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
* Move ec2_vpc_route_table tests into group 4
* ec2_vpc_route_table - Use retries more consistently.
* ec2_vpc_route_table_info - boto3 migration
* changelog
* Add return value documentation
* catch WaiterError for cleaner error messages
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
* Move ec2_vpc_route_table tests into group 4
* ec2_vpc_route_table - Use retries more consistently.
* ec2_vpc_route_table_info - boto3 migration
* changelog
* Add return value documentation
* catch WaiterError for cleaner error messages
danielcotton pushed a commit to danielcotton/community.aws that referenced this pull request Nov 23, 2021
* Move ec2_vpc_route_table tests into group 4
* ec2_vpc_route_table - Use retries more consistently.
* ec2_vpc_route_table_info - boto3 migration
* changelog
* Add return value documentation
* catch WaiterError for cleaner error messages
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request May 25, 2022
…nimums and remove tests for old versions (ansible-collections#442)

Emit a warning if botocore/boto3 versions don't meet our supported minimums and remove tests for old versions

SUMMARY
Rather than checking that we support (old) boto3/botocore features, emit a warning if botocore/boto3 are less than the supported versions.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
plugins/module_utils/core.py
plugins/modules/aws_s3.py
plugins/modules/cloudformation.py
plugins/modules/ec2_group.py
plugins/modules/ec2_instance.py
plugins/modules/ec2_instance_info.py
plugins/modules/ec2_vpc_subnet.py
plugins/modules/s3_bucket.py
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request May 25, 2022
* Move ec2_vpc_route_table tests into group 4
* ec2_vpc_route_table - Use retries more consistently.
* ec2_vpc_route_table_info - boto3 migration
* changelog
* Add return value documentation
* catch WaiterError for cleaner error messages

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@dfb20a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review feature This issue/PR relates to a feature request integration tests/integration module module plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants