-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup ec2_vpc_route_table(_info) #442
Merged
tremble
merged 6 commits into
ansible-collections:main
from
tremble:stability/ec2_vpc_route_table
Mar 10, 2021
Merged
Cleanup ec2_vpc_route_table(_info) #442
tremble
merged 6 commits into
ansible-collections:main
from
tremble:stability/ec2_vpc_route_table
Mar 10, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
WIP
Work in progress
feature
This issue/PR relates to a feature request
integration
tests/integration
module
module
plugins
plugin (any type)
tests
tests
labels
Feb 24, 2021
tremble
force-pushed
the
stability/ec2_vpc_route_table
branch
from
February 25, 2021 14:37
fb12fde
to
668fd81
Compare
tremble
changed the title
[WIP] Cleanup ec2_vpc_route_table(_info)
Cleanup ec2_vpc_route_table(_info)
Feb 25, 2021
tremble
force-pushed
the
stability/ec2_vpc_route_table
branch
from
March 10, 2021 08:55
668fd81
to
032f209
Compare
alinabuzachis
approved these changes
Mar 10, 2021
Has approval and tests are passing. merging |
danquixote
pushed a commit
to danquixote/community.aws
that referenced
this pull request
May 16, 2021
* Move ec2_vpc_route_table tests into group 4 * ec2_vpc_route_table - Use retries more consistently. * ec2_vpc_route_table_info - boto3 migration * changelog * Add return value documentation * catch WaiterError for cleaner error messages
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 16, 2021
* Move ec2_vpc_route_table tests into group 4 * ec2_vpc_route_table - Use retries more consistently. * ec2_vpc_route_table_info - boto3 migration * changelog * Add return value documentation * catch WaiterError for cleaner error messages This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@dfb20a3
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
* Move ec2_vpc_route_table tests into group 4 * ec2_vpc_route_table - Use retries more consistently. * ec2_vpc_route_table_info - boto3 migration * changelog * Add return value documentation * catch WaiterError for cleaner error messages
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
* Move ec2_vpc_route_table tests into group 4 * ec2_vpc_route_table - Use retries more consistently. * ec2_vpc_route_table_info - boto3 migration * changelog * Add return value documentation * catch WaiterError for cleaner error messages
danielcotton
pushed a commit
to danielcotton/community.aws
that referenced
this pull request
Nov 23, 2021
* Move ec2_vpc_route_table tests into group 4 * ec2_vpc_route_table - Use retries more consistently. * ec2_vpc_route_table_info - boto3 migration * changelog * Add return value documentation * catch WaiterError for cleaner error messages
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
…nimums and remove tests for old versions (ansible-collections#442) Emit a warning if botocore/boto3 versions don't meet our supported minimums and remove tests for old versions SUMMARY Rather than checking that we support (old) boto3/botocore features, emit a warning if botocore/boto3 are less than the supported versions. ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/module_utils/core.py plugins/modules/aws_s3.py plugins/modules/cloudformation.py plugins/modules/ec2_group.py plugins/modules/ec2_instance.py plugins/modules/ec2_instance_info.py plugins/modules/ec2_vpc_subnet.py plugins/modules/s3_bucket.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> Reviewed-by: None <None>
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
* Move ec2_vpc_route_table tests into group 4 * ec2_vpc_route_table - Use retries more consistently. * ec2_vpc_route_table_info - boto3 migration * changelog * Add return value documentation * catch WaiterError for cleaner error messages This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@dfb20a3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
community_review
feature
This issue/PR relates to a feature request
integration
tests/integration
module
module
plugins
plugin (any type)
tests
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
ISSUE TYPE
COMPONENT NAME
ec2_vpc_route_table
ec2_vpc_route_table_info
ADDITIONAL INFORMATION