Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DNM Promote ec2_placement_group* to amazon.aws #2181

Merged
merged 6 commits into from
Oct 25, 2024
Merged

DNM Promote ec2_placement_group* to amazon.aws #2181

merged 6 commits into from
Oct 25, 2024

Conversation

GomathiselviS
Copy link
Collaborator

@GomathiselviS GomathiselviS commented Oct 16, 2024 •
edited
Loading

SUMMARY

This PR migrates ec2_palcement_group* modules from community.aws to amazon.aws - ansible-collections/amazon.aws#2346
Refer : https://issues.redhat.com/browse/ACA-1889

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/ansible-collections/community.aws for 2181,9072a4726d7b9c8613c88585ab18c91fc7bd7715

@GomathiselviS GomathiselviS force-pushed the promote_ec2_placement_group branch from 9072a47 to 47adac9 Compare October 16, 2024 16:23
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 16, 2024 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/7d5d20ea4cea4385958c11be84609ed4

❌ ansible-galaxy-importer FAILURE in 6m 10s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 17s
✔️ ansible-test-splitter SUCCESS in 4m 04s
Skipped 22 jobs

abikouo
abikouo requested changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@abikouo abikouo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! Except the file that should be kept.

changelogs/fragments/20240613_ec2_placement_group_tags.yml Outdated Show resolved Hide resolved
@GomathiselviS GomathiselviS force-pushed the promote_ec2_placement_group branch from 47adac9 to 801d813 Compare October 17, 2024 13:14
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/ansible-collections/community.aws for 2181,801d813fa31acd51c573a7628b56b680c7cc1473

@GomathiselviS GomathiselviS force-pushed the promote_ec2_placement_group branch from 801d813 to e83d251 Compare October 17, 2024 15:15
@GomathiselviS GomathiselviS requested a review from abikouo October 17, 2024 15:20
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/282ad5de01db42249dc64ace0aea5e26

✔️ ansible-galaxy-importer SUCCESS in 3m 19s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 41s
✔️ ansible-test-splitter SUCCESS in 4m 09s
Skipped 22 jobs

@GomathiselviS GomathiselviS changed the title Promote ec2_placement_group* to amazon.aws DNM Promote ec2_placement_group* to amazon.aws Oct 17, 2024
@GomathiselviS GomathiselviS mentioned this pull request Oct 17, 2024
Merged
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/ansible-collections/community.aws for 2181,9895a6d3ba6425042c589a1455eb968f900c6d9d

GomathiselviS and others added 5 commits October 25, 2024 13:45
@GomathiselviS @alinabuzachis
Remove modules
36dc3fd
@GomathiselviS @alinabuzachis
Update runtime
77983e2
@GomathiselviS @alinabuzachis
Add changelog fragment
9e61fd3
@GomathiselviS @alinabuzachis
Revert changelog
3d8e3a7
@abikouo @alinabuzachis
DNM - Migrate modules ec2_vpc_egress_igw and tests (ansible-collectio…
7b3f429 
…ns#2169)

Depends-On: ansible-collections/amazon.aws#2327

Remove ec2_vpc_egress_igw,ec2_vpc_egress_igw modules and tests, these modules have been migrated to amazon.aws collection.
Update runtime.yml with redirects to that collection
Update ignore files

Reviewed-by: GomathiselviS <[email protected]>
Reviewed-by: Alina Buzachis
@alinabuzachis alinabuzachis force-pushed the promote_ec2_placement_group branch from 9895a6d to 7b3f429 Compare October 25, 2024 11:46
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/e4c96e3934884eef831aa93c86f3a688

✔️ ansible-galaxy-importer SUCCESS in 3m 17s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 14s
✔️ ansible-test-splitter SUCCESS in 3m 59s
Skipped 22 jobs

@alinabuzachis alinabuzachis added the mergeit Merge the PR (SoftwareFactory) label Oct 25, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/43b476cd1c784cfe8297c4e1b73bf379

❌ ansible-galaxy-importer FAILURE in 6m 44s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 07s
✔️ ansible-test-splitter SUCCESS in 3m 57s
Skipped 22 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit dd5fd1d into ansible-collections:main Oct 25, 2024
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abikouo abikouo abikouo approved these changes

@alinabuzachis alinabuzachis alinabuzachis approved these changes

@tremble tremble Awaiting requested review from tremble

@mandar242 mandar242 Awaiting requested review from mandar242

Assignees
No one assigned
Labels
mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GomathiselviS @alinabuzachis @abikouo