-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DNM - Migrate modules ec2_vpc_egress_igw and tests #2327
DNM - Migrate modules ec2_vpc_egress_igw and tests #2327
Conversation
abikouo
commented
Oct 9, 2024
•
edited
Loading
edited
- Migrage modules ec2_vpc_egress_igw and tests from collection community.aws
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 26s |
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 27s |
d1b1a8b
to
2b643de
Compare
This change depends on a change that failed to merge. Change #2334 is needed. |
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@eb75681
This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@13b104b
* Rename core collection Rename references to ansible.amazon to amazon.aws. * Rename community.amazon to community.aws Fix pep8 line lengths for rewritten amazon.aws imports * Missed a path in shippable.sh * Dependency repos moved This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@235c5db
* Remove ANSIBLE_METADATA entirely, see ansible/ansible/pull/69454. Remove `license` field from galaxy.yml, in favor of `license_file`. This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@05672a6
Updated module examples with FQCN Signed-off-by: Abhijeet Kasurde <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@98173ae
Co-authored-by: Ezekiel Hendrickson <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@10853d9
* Update docs Remove .git from repo url so links in readme will generate correctly Add required ansible version Run latest version of add_docs.py Add version_added string to modules * galaxy.yml was missing authors This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@96ee268
* Update comments to reference AnsibleAWSModule rather than AnsibleModule * Bulk re-order imports and split onto one from import per-line. * Add AnsibleAWSModule imports * Migrate boto 2 based modules to AnsibleAWSModule * Move boto3-only modules over to AnsibleAWSModule * Remove extra ec2_argument_spec calls - not needed now we're using AnsibleAWSModule * Remove most HAS_BOTO3 code, it's handled by AnsibleAWSModule * Handle missing Boto 2 consistently (HAS_BOTO) * Remove AnsibleModule imports * Changelog fragment This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@818c6d2
* Reorder imports * Make use of is_boto3_error_message * Mass-migration over to is_boto3_error_code * Remove unused imports * unused vars in exception * Improve consistency around catching BotoCoreError and ClientError * Remove unused imports * Remove unused 'PolicyError' from iam_policy_info * Avoid catching botocore.exceptions.ClientError when we only want some error codes * Import camel_dict_to_snake_dict/snake_dict_to_camel_dict from ansible.module_utils.common.dict_transformations This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@4cf52ef
* Bulk migration to module_defaults * Tests for missing creds/region * Move dms_identifier and dms_sg_identifier into defaults This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@365b6ef
* ec2_vpc_egress_igw - use connection rather than 'conn' for consistency * ec2_vpc_egress_igw - enable retry decorator * changelog This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@f2d4851
This collection has been operating on Zuul CI for some weeks now This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@4e0d83c
…ent meta data (ansible-collections#1090) For consistency - add empty dependencies file to targets with no current meta data SUMMARY For consistency - add empty dependencies file to targets with no current meta data ISSUE TYPE Feature Pull Request COMPONENT NAME tests/integration/targets ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@9638580
…le-collections#1475) tests/ec2_vpc_egress_igw: avoid a InvalidVpcId.Malformed error Ensures the "test failure with non-existent VPC ID" test uses a properly formatted VPC ID. Otherwise, the API now returns the following error: "error": { "code": "InvalidVpcId.Malformed", "message": "The vpc ID vpc-012345678 is malformed" }, Reviewed-by: Mark Chappell <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@fe83fcb
…collections#1459) Update extends_documentation_fragment with amazon.aws.boto3 Depends-On: ansible/ansible-zuul-jobs#1654 SUMMARY As per ansible-collections#985 add amazon.aws.boto3. ISSUE TYPE Docs Pull Request COMPONENT NAME several Reviewed-by: Jill R <None> Reviewed-by: Mark Chappell <None> Reviewed-by: Markus Bergholz <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@bd3c03f
…ons#1632) Ansible User-Agent identification for community.aws SUMMARY The value will be similar to this APN/1.0 Ansible/2.14.1 community.aws/6.0.0-dev0 ISSUE TYPE Feature Pull Request Reviewed-by: Mark Chappell <None> Reviewed-by: Bikouo Aubin <None> Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@a8cbce2
Cleanup headers and imports SUMMARY Mass update of imports, docs fragments and file headers Many of the amazon.aws module_utils and docs fragments got moved about, update community.aws to reflect this. Consistently apply the comment headers as documented at https://docs.ansible.com/ansible/devel/dev_guide/developing_modules_documenting.html#python-shebang-utf-8-coding ISSUE TYPE Docs Pull Request Feature Pull Request COMPONENT NAME ADDITIONAL INFORMATION Header cleanup based upon: https://docs.ansible.com/ansible/devel/dev_guide/developing_modules_documenting.html#python-shebang-utf-8-coding Begin your Ansible module with #!/usr/bin/python - this “shebang” allows ansible_python_interpreter to work. Follow the shebang immediately with # -*- coding: utf-8 -*- to clarify that the file is UTF-8 encoded. and https://docs.ansible.com/ansible/devel/dev_guide/developing_modules_documenting.html#copyright-and-license After the shebang and UTF-8 coding, add a copyright line with the original copyright holder and a license declaration. The license declaration should be ONLY one line, not the full GPL prefix. ... Additions to the module (for instance, rewrites) are not permitted to add additional copyright lines other than the default copyright statement if missing: Reviewed-by: Alina Buzachis This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@a4f20bf
* Black prep * Black * changelog * Fix pylint unused-import in tests * Split SSM connection plugin changes * disable glue tests - bucket's missing * Disable s3_logging and s3_sync tests This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@2c4575c
Bulk migration to Python 3.6 f-strings SUMMARY We've dropped support for Python <3.6, bulk migrate to fstrings and perform some general string cleanup A combination of black --preview flynt some manual cleanup ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/ tests/ ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@de33821
…ollections#1921) Mass update of docs and tests (credentials/session tokens) SUMMARY We had a cleanup of credentials/session parameters which included a batch of deprecations and renames. Ensure that all of our tests and docs are using the 'canonical' names ISSUE TYPE Docs Pull Request COMPONENT NAME plugins/modules/batch_compute_environment.py plugins/modules/cloudformation_exports_info.py plugins/modules/ec2_vpc_vpn.py plugins/modules/elasticache.py plugins/modules/elasticache_parameter_group.py plugins/modules/elasticache_snapshot.py plugins/modules/ses_rule_set.py plugins/modules/sts_assume_role.py plugins/modules/sts_session_token.py tests/integration ADDITIONAL INFORMATION See also ansible-collections#1172 ansible-collections#1714 Reviewed-by: Alina Buzachis This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@4a5b50e
…s#2036) ansible-lint (documentation) cleanup for plugins/ SUMMARY Fixes an array of ansible-lint failures in plugins/ Adds ansible-lint plugins/ to tox -m lint ISSUE TYPE Docs Pull Request COMPONENT NAME plugins/ ADDITIONAL INFORMATION docs changes only (no changelog fragment needed) Reviewed-by: Alina Buzachis This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@6dd4a00
…#2152) SUMMARY Refactor module ec2_vpc_egress_igw to use shared code from amazon.aws.plugins.module_utils.ec2 ec2_vpc_egress_igw - add support for tagging ISSUE TYPE Feature Pull Request New Module Pull Request COMPONENT NAME ec2_vpc_egress_igw Reviewed-by: Alina Buzachis Reviewed-by: Bikouo Aubin Reviewed-by: GomathiselviS This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@7b51659
2b643de
to
f76958a
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 21s |
Depends-On: ansible-collections/amazon.aws#2327 Remove ec2_vpc_egress_igw,ec2_vpc_egress_igw modules and tests, these modules have been migrated to amazon.aws collection. Update runtime.yml with redirects to that collection Update ignore files Reviewed-by: GomathiselviS <[email protected]> Reviewed-by: Alina Buzachis
…ns#2169) Depends-On: ansible-collections/amazon.aws#2327 Remove ec2_vpc_egress_igw,ec2_vpc_egress_igw modules and tests, these modules have been migrated to amazon.aws collection. Update runtime.yml with redirects to that collection Update ignore files Reviewed-by: GomathiselviS <[email protected]> Reviewed-by: Alina Buzachis
…ns#2169) Depends-On: ansible-collections/amazon.aws#2327 Remove ec2_vpc_egress_igw,ec2_vpc_egress_igw modules and tests, these modules have been migrated to amazon.aws collection. Update runtime.yml with redirects to that collection Update ignore files Reviewed-by: GomathiselviS <[email protected]> Reviewed-by: Alina Buzachis
…ns#2169) Depends-On: ansible-collections/amazon.aws#2327 Remove ec2_vpc_egress_igw,ec2_vpc_egress_igw modules and tests, these modules have been migrated to amazon.aws collection. Update runtime.yml with redirects to that collection Update ignore files Reviewed-by: GomathiselviS <[email protected]> Reviewed-by: Alina Buzachis
…ns#2169) Depends-On: ansible-collections/amazon.aws#2327 Remove ec2_vpc_egress_igw,ec2_vpc_egress_igw modules and tests, these modules have been migrated to amazon.aws collection. Update runtime.yml with redirects to that collection Update ignore files Reviewed-by: GomathiselviS <[email protected]> Reviewed-by: Alina Buzachis
…ns#2169) Depends-On: ansible-collections/amazon.aws#2327 Remove ec2_vpc_egress_igw,ec2_vpc_egress_igw modules and tests, these modules have been migrated to amazon.aws collection. Update runtime.yml with redirects to that collection Update ignore files Reviewed-by: GomathiselviS <[email protected]> Reviewed-by: Alina Buzachis
…ns#2169) Depends-On: ansible-collections/amazon.aws#2327 Remove ec2_vpc_egress_igw,ec2_vpc_egress_igw modules and tests, these modules have been migrated to amazon.aws collection. Update runtime.yml with redirects to that collection Update ignore files Reviewed-by: GomathiselviS <[email protected]> Reviewed-by: Alina Buzachis
…ns#2169) Depends-On: ansible-collections/amazon.aws#2327 Remove ec2_vpc_egress_igw,ec2_vpc_egress_igw modules and tests, these modules have been migrated to amazon.aws collection. Update runtime.yml with redirects to that collection Update ignore files Reviewed-by: GomathiselviS <[email protected]> Reviewed-by: Alina Buzachis