Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote ec2 vpc igw #421

Merged
merged 23 commits into from
Aug 27, 2021
Merged

Promote ec2 vpc igw #421

merged 23 commits into from
Aug 27, 2021

Conversation

jillr
Copy link
Collaborator

@jillr jillr commented Jul 27, 2021 •
edited
Loading

SUMMARY

Migrate ec2_vpc_igw* modules and tests

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ec2_vpc_igw, ec2_vpc_igw_info

Depends-On: ansible/ansible-zuul-jobs/pull/1014

@ansibullbot
Copy link

cc @s-hertel @tremble @wimnat
click here for bot help

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request integration tests/integration module module needs_triage new_module New module new_plugin New plugin plugins plugin (any type) tests tests labels Jul 27, 2021
@jillr jillr mentioned this pull request Jul 27, 2021
Merged
@jillr
Copy link
Collaborator Author

jillr commented Jul 28, 2021

ruamel.yaml is adding the extra spaces into runtime.yml when it rewrites the file; I'll fix that to make the diff nicer.

@jillr jillr force-pushed the promote_ec2_vpc_igw branch from 38d77bb to 9ae0a6d Compare July 28, 2021 23:42
@jillr
Copy link
Collaborator Author

jillr commented Aug 2, 2021

recheck

@ansibullbot ansibullbot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed community_review labels Aug 10, 2021
@jillr jillr force-pushed the promote_ec2_vpc_igw branch from a25e87e to 29626ed Compare August 20, 2021 16:36
@ansibullbot ansibullbot added community_review and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Aug 20, 2021
@jillr jillr requested review from tremble and goneri August 20, 2021 22:22
@jillr jillr requested a review from tremble August 26, 2021 18:50
@jillr jillr added the gate label Aug 26, 2021
ansible-zuul[bot]
ansible-zuul bot approved these changes Aug 26, 2021
View reviewed changes
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ansibullbot
Copy link

@jillr this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

tremble and others added 13 commits August 26, 2021 14:08
@tremble @jillr
Cleanup: Bulk Migration from boto3_conn to module.client() (ansible-c…
727abb3 
…ollections#188)

* Migrate from boto3_conn to module.client
* Simplify error handling when creating connections
* Simplify Region handling
* Remove unused imports
* Changelog

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@6bdf00d
@tremble @jillr
Cleanup IGW modules (ansible-collections#318)
b48012e 
* import order

* Add retry decorators

* Switch tests to using module_defaults

* module_defaults

* Add initial _info tests

* Handle Boto Errors with fail_json_aws

* Test state=absent when IGW missing

* Support not purging tags

* Support converting Tags from boto to dict

* Add tagging tests

* Use random CIDR for VPC

* Add check_mode tests

* changelog

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@d6ff623
@tremble @jillr
Yet more integration test aliases file cleanup (ansible-collections#431)
0b46460 
* More aliases cleanup
* Mark ec2_classic_lb tests unstable
* Add more comments about why tests aren't enabled

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cb55efa
@alinabuzachis @jillr
ec2_vpc_igw: increase integration tests coverage and code cleaning (a…
4b8c406 
…nsible-collections#386)

* Internet gateway: add missing integration tests and code check
 * Add CamelCase tags integration test
 * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings
 * Add additional integration tests for ec2_vpc_igw_info module

Signed-off-by: Alina Buzachis <[email protected]>

* Internet Gateway - integration tests
 * Fix Internet Gatways search by tags

* * Apply reviewer suggestions
        * Better error handling for the waiter

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cff6d00
@alinabuzachis @tremble @jillr
ec2_vpc_igw (_info) - documentation improvement (ansible-collections#495
13aba45 
)

* * ec2_vpc_igw (_info) - documentation improvement

Signed-off-by: Alina Buzachis <[email protected]>

* Whitespace linting

Co-authored-by: Mark Chappell <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@1a0c20c
@tremble @jillr
Update the default module requirements from python 2.6/boto to python…
0004445 
… 3.6/boto3

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@c097c55
@jillr
Remove shippable references from repo
7219ec5 
This collection has been operating on Zuul CI for some weeks now

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@4e0d83c
@jillr
Update runtime
822d50c
@jillr
Update FQDN
919755e
@jillr
Remove collection reference inside the tests
030b688
@jillr
Add changelog fragment
bdef6a9
@jillr
facts modules should be symlinks
7b2d91d
@jillr
Add sanity ignore for deprecation date in 2.9
2e441d4
@jillr jillr force-pushed the promote_ec2_vpc_igw branch from 4e9855a to 2e441d4 Compare August 26, 2021 21:09
@ansible-zuul ansible-zuul bot removed the gate label Aug 26, 2021
@ansibullbot ansibullbot added community_review and removed merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Aug 26, 2021
@jillr jillr added the gate label Aug 26, 2021
@jillr jillr dismissed tremble’s stale review August 27, 2021 00:36

fixed what you asked for!

@jillr jillr added gate and removed gate labels Aug 27, 2021
@ansible-zuul ansible-zuul bot merged commit b805fd9 into ansible-collections:main Aug 27, 2021
ansible-zuul bot added a commit to ansible-collections/community.aws that referenced this pull request Aug 27, 2021
@ansible-zuul
Merge pull request #657 from jillr/promote_ec2_vpc_igw
19cc031 
Remove ec2_vpc_igw

SUMMARY
Migrate ec2_vpc_igw* modules and tests
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
ec2_vpc_igw, ec2_vpc_igw_info
ADDITIONAL INFORMATION
DNM until ansible-collections/amazon.aws/pull/421 merges

Reviewed-by: Mark Chappell <None>
Reviewed-by: None <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
@tremble
Add retries to ec2_vpc_egress_igw (ansible-collections#421)
9aab5be 
* ec2_vpc_egress_igw - use connection rather than 'conn' for consistency

* ec2_vpc_egress_igw - enable retry decorator

* changelog
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
@tremble @abikouo
Add retries to ec2_vpc_egress_igw (ansible-collections#421)
13f6a61 
* ec2_vpc_egress_igw - use connection rather than 'conn' for consistency

* ec2_vpc_egress_igw - enable retry decorator

* changelog
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
@tremble
Add retries to ec2_vpc_egress_igw (ansible-collections#421)
f2d4851 
* ec2_vpc_egress_igw - use connection rather than 'conn' for consistency

* ec2_vpc_egress_igw - enable retry decorator

* changelog
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 9, 2024
@tremble @abikouo
Add retries to ec2_vpc_egress_igw (ansible-collections#421)
aae1924 
* ec2_vpc_egress_igw - use connection rather than 'conn' for consistency

* ec2_vpc_egress_igw - enable retry decorator

* changelog

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@f2d4851
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 14, 2024
@tremble @abikouo
Add retries to ec2_vpc_egress_igw (ansible-collections#421)
103e6f3 
* ec2_vpc_egress_igw - use connection rather than 'conn' for consistency

* ec2_vpc_egress_igw - enable retry decorator

* changelog

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@f2d4851
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 15, 2024
@tremble @abikouo
Add retries to ec2_vpc_egress_igw (ansible-collections#421)
1c77177 
* ec2_vpc_egress_igw - use connection rather than 'conn' for consistency

* ec2_vpc_egress_igw - enable retry decorator

* changelog

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@f2d4851
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ansible-zuul ansible-zuul[bot] ansible-zuul[bot] approved these changes

@gravesm gravesm gravesm approved these changes

@goneri goneri Awaiting requested review from goneri

@tremble tremble Awaiting requested review from tremble

Assignees
No one assigned
Labels
community_review feature This issue/PR relates to a feature request integration tests/integration module module new_module New module new_plugin New plugin plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jillr @ansibullbot @tremble @gravesm @Akasurde @flowerysong @alinabuzachis