Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ec2_metadata_facts: fixing generated doc render #431

Merged
merged 3 commits into from
Aug 19, 2021
Merged

ec2_metadata_facts: fixing generated doc render #431

merged 3 commits into from
Aug 19, 2021

Conversation

mandar242
Copy link
Contributor

SUMMARY

Fixing the rendering of generated docs for ec2_metadata_facts as items within < > tags are being parsed out.
Fixes #249

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ec2_metadata_facts

@ansibullbot
Copy link

cc @jillr @roadmapper @s-hertel @silviud @tremble @wimnat
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review module module needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) labels Aug 2, 2021
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Aug 3, 2021
@tremble @alinabuzachis
Yet more integration test aliases file cleanup (ansible-collections#431)
343ae16 
* More aliases cleanup
* Mark ec2_classic_lb tests unstable
* Add more comments about why tests aren't enabled

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cb55efa
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Aug 3, 2021
@tremble @alinabuzachis
Yet more integration test aliases file cleanup (ansible-collections#431)
8c3f24d 
* More aliases cleanup
* Mark ec2_classic_lb tests unstable
* Add more comments about why tests aren't enabled

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cb55efa
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Aug 4, 2021
@tremble @alinabuzachis
Yet more integration test aliases file cleanup (ansible-collections#431)
4ce5590 
* More aliases cleanup
* Mark ec2_classic_lb tests unstable
* Add more comments about why tests aren't enabled

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cb55efa
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Aug 4, 2021
@tremble @alinabuzachis
Yet more integration test aliases file cleanup (ansible-collections#431)
5e0018b 
* More aliases cleanup
* Mark ec2_classic_lb tests unstable
* Add more comments about why tests aren't enabled

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cb55efa
alinabuzachis
alinabuzachis reviewed Aug 4, 2021
View reviewed changes
Copy link
Collaborator

@alinabuzachis alinabuzachis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mandar242. I left some comments.

plugins/modules/ec2_metadata_facts.py Outdated Show resolved Hide resolved
plugins/modules/ec2_metadata_facts.py Outdated Show resolved Hide resolved
plugins/modules/ec2_metadata_facts.py Outdated Show resolved Hide resolved
plugins/modules/ec2_metadata_facts.py Outdated Show resolved Hide resolved
plugins/modules/ec2_metadata_facts.py Outdated Show resolved Hide resolved
plugins/modules/ec2_metadata_facts.py Outdated Show resolved Hide resolved
plugins/modules/ec2_metadata_facts.py Outdated Show resolved Hide resolved
plugins/modules/ec2_metadata_facts.py Outdated Show resolved Hide resolved
plugins/modules/ec2_metadata_facts.py Outdated Show resolved Hide resolved
plugins/modules/ec2_metadata_facts.py Outdated Show resolved Hide resolved
@mandar242
Copy link
Contributor Author

Thank you @mandar242. I left some comments.

Thank you for the review @alinabuzachis.

alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Aug 6, 2021
@tremble @alinabuzachis
Yet more integration test aliases file cleanup (ansible-collections#431)
e6110d3 
* More aliases cleanup
* Mark ec2_classic_lb tests unstable
* Add more comments about why tests aren't enabled

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cb55efa
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Aug 6, 2021
@tremble @alinabuzachis
Yet more integration test aliases file cleanup (ansible-collections#431)
08516ff 
* More aliases cleanup
* Mark ec2_classic_lb tests unstable
* Add more comments about why tests aren't enabled

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cb55efa
@mandar242 mandar242 requested a review from alinabuzachis August 6, 2021 17:36
@tremble
Copy link
Contributor

tremble commented Aug 9, 2021

recheck

@ansibullbot ansibullbot removed needs_triage new_contributor Help guide this first time contributor labels Aug 9, 2021
@tremble
Copy link
Contributor

tremble commented Aug 9, 2021

recheck

@mandar242 mandar242 closed this Aug 10, 2021
@mandar242 mandar242 deleted the issues-249-fixing-doc-render branch August 10, 2021 00:49
@mandar242 mandar242 restored the issues-249-fixing-doc-render branch August 10, 2021 00:51
@mandar242 mandar242 reopened this Aug 10, 2021
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Sep 21, 2022
@tremble @alinabuzachis
Yet more integration test aliases file cleanup (ansible-collections#431)
611bc7c 
* More aliases cleanup
* Mark ec2_classic_lb tests unstable
* Add more comments about why tests aren't enabled

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cb55efa
goneri pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Sep 21, 2022
@tremble @goneri
Yet more integration test aliases file cleanup (ansible-collections#431)
8d54a44 
* More aliases cleanup
* Mark ec2_classic_lb tests unstable
* Add more comments about why tests aren't enabled

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cb55efa
goneri pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Sep 21, 2022
@tremble @goneri
Yet more integration test aliases file cleanup (ansible-collections#431)
2c4a3b5 
* More aliases cleanup
* Mark ec2_classic_lb tests unstable
* Add more comments about why tests aren't enabled

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cb55efa
goneri pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Sep 21, 2022
@tremble @goneri
Yet more integration test aliases file cleanup (ansible-collections#431)
28caab9 
* More aliases cleanup
* Mark ec2_classic_lb tests unstable
* Add more comments about why tests aren't enabled

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cb55efa
goneri pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Sep 21, 2022
@tremble @goneri
Yet more integration test aliases file cleanup (ansible-collections#431)
d4b3b6a 
* More aliases cleanup
* Mark ec2_classic_lb tests unstable
* Add more comments about why tests aren't enabled

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cb55efa
goneri pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Sep 21, 2022
@tremble @goneri
Yet more integration test aliases file cleanup (ansible-collections#431)
cb0598f 
* More aliases cleanup
* Mark ec2_classic_lb tests unstable
* Add more comments about why tests aren't enabled

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cb55efa
goneri pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Sep 21, 2022
@tremble @goneri
Yet more integration test aliases file cleanup (ansible-collections#431)
d02a795 
* More aliases cleanup
* Mark ec2_classic_lb tests unstable
* Add more comments about why tests aren't enabled

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cb55efa
goneri pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Sep 21, 2022
@tremble @goneri
Yet more integration test aliases file cleanup (ansible-collections#431)
4c2b076 
* More aliases cleanup
* Mark ec2_classic_lb tests unstable
* Add more comments about why tests aren't enabled

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cb55efa
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
@tremble
Yet more integration test aliases file cleanup (ansible-collections#431)
cb55efa 
* More aliases cleanup
* Mark ec2_classic_lb tests unstable
* Add more comments about why tests aren't enabled
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 19, 2024
@tremble @abikouo
Yet more integration test aliases file cleanup (ansible-collections#431)
2cb5ec6 
* More aliases cleanup
* Mark ec2_classic_lb tests unstable
* Add more comments about why tests aren't enabled

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cb55efa
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 15, 2024
@tremble @abikouo
Yet more integration test aliases file cleanup (ansible-collections#431)
c548a53 
* More aliases cleanup
* Mark ec2_classic_lb tests unstable
* Add more comments about why tests aren't enabled

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cb55efa
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 16, 2024
@tremble @abikouo
Yet more integration test aliases file cleanup (ansible-collections#431)
921c6e3 
* More aliases cleanup
* Mark ec2_classic_lb tests unstable
* Add more comments about why tests aren't enabled

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cb55efa
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Oct 16, 2024
@tremble @alinabuzachis
Yet more integration test aliases file cleanup (ansible-collections#431)
decf8f9 
* More aliases cleanup
* Mark ec2_classic_lb tests unstable
* Add more comments about why tests aren't enabled

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cb55efa
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Oct 16, 2024
@tremble @alinabuzachis
Yet more integration test aliases file cleanup (ansible-collections#431)
63b36e0 
* More aliases cleanup
* Mark ec2_classic_lb tests unstable
* Add more comments about why tests aren't enabled

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cb55efa
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 17, 2024
@tremble @abikouo
Yet more integration test aliases file cleanup (ansible-collections#431)
2550725 
* More aliases cleanup
* Mark ec2_classic_lb tests unstable
* Add more comments about why tests aren't enabled

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cb55efa
mandar242 pushed a commit to mandar242/amazon.aws that referenced this pull request Oct 23, 2024
@tremble @mandar242
Yet more integration test aliases file cleanup (ansible-collections#431)
d4afe00 
* More aliases cleanup
* Mark ec2_classic_lb tests unstable
* Add more comments about why tests aren't enabled

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cb55efa
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Oct 23, 2024
@tremble @alinabuzachis
Yet more integration test aliases file cleanup (ansible-collections#431)
53fccac 
* More aliases cleanup
* Mark ec2_classic_lb tests unstable
* Add more comments about why tests aren't enabled

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cb55efa
mandar242 pushed a commit to mandar242/amazon.aws that referenced this pull request Oct 23, 2024
@tremble @mandar242
Yet more integration test aliases file cleanup (ansible-collections#431)
73203bf 
* More aliases cleanup
* Mark ec2_classic_lb tests unstable
* Add more comments about why tests aren't enabled

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cb55efa
mandar242 pushed a commit to mandar242/amazon.aws that referenced this pull request Oct 23, 2024
@tremble @mandar242
Yet more integration test aliases file cleanup (ansible-collections#431)
f4d6881 
* More aliases cleanup
* Mark ec2_classic_lb tests unstable
* Add more comments about why tests aren't enabled

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cb55efa
mandar242 pushed a commit to mandar242/amazon.aws that referenced this pull request Oct 23, 2024
@tremble @mandar242
Yet more integration test aliases file cleanup (ansible-collections#431)
f2746b6 
* More aliases cleanup
* Mark ec2_classic_lb tests unstable
* Add more comments about why tests aren't enabled

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cb55efa
mandar242 pushed a commit to mandar242/amazon.aws that referenced this pull request Oct 23, 2024
@tremble @mandar242
Yet more integration test aliases file cleanup (ansible-collections#431)
e343e06 
* More aliases cleanup
* Mark ec2_classic_lb tests unstable
* Add more comments about why tests aren't enabled

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cb55efa
mandar242 pushed a commit to mandar242/amazon.aws that referenced this pull request Oct 23, 2024
@tremble @mandar242
Yet more integration test aliases file cleanup (ansible-collections#431)
3160c51 
* More aliases cleanup
* Mark ec2_classic_lb tests unstable
* Add more comments about why tests aren't enabled

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cb55efa
mandar242 pushed a commit to mandar242/amazon.aws that referenced this pull request Oct 24, 2024
@tremble @mandar242
Yet more integration test aliases file cleanup (ansible-collections#431)
be35ffd 
* More aliases cleanup
* Mark ec2_classic_lb tests unstable
* Add more comments about why tests aren't enabled

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cb55efa
mandar242 pushed a commit to mandar242/amazon.aws that referenced this pull request Oct 24, 2024
@tremble @mandar242
Yet more integration test aliases file cleanup (ansible-collections#431)
afb3dfe 
* More aliases cleanup
* Mark ec2_classic_lb tests unstable
* Add more comments about why tests aren't enabled

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cb55efa
mandar242 pushed a commit to mandar242/amazon.aws that referenced this pull request Oct 24, 2024
@tremble @mandar242
Yet more integration test aliases file cleanup (ansible-collections#431)
1dfcb55 
* More aliases cleanup
* Mark ec2_classic_lb tests unstable
* Add more comments about why tests aren't enabled

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cb55efa
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Oct 24, 2024
@tremble @alinabuzachis
Yet more integration test aliases file cleanup (ansible-collections#431)
eef30a4 
* More aliases cleanup
* Mark ec2_classic_lb tests unstable
* Add more comments about why tests aren't enabled

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cb55efa
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Oct 24, 2024
@tremble @alinabuzachis
Yet more integration test aliases file cleanup (ansible-collections#431)
0c4c71b 
* More aliases cleanup
* Mark ec2_classic_lb tests unstable
* Add more comments about why tests aren't enabled

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cb55efa
mandar242 pushed a commit to mandar242/amazon.aws that referenced this pull request Oct 24, 2024
@tremble @mandar242
Yet more integration test aliases file cleanup (ansible-collections#431)
8a9eacb 
* More aliases cleanup
* Mark ec2_classic_lb tests unstable
* Add more comments about why tests aren't enabled

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cb55efa
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Oct 24, 2024
@tremble @alinabuzachis
Yet more integration test aliases file cleanup (ansible-collections#431)
f8db233 
* More aliases cleanup
* Mark ec2_classic_lb tests unstable
* Add more comments about why tests aren't enabled

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cb55efa
mandar242 pushed a commit to mandar242/amazon.aws that referenced this pull request Oct 24, 2024
@tremble @mandar242
Yet more integration test aliases file cleanup (ansible-collections#431)
c9c6977 
* More aliases cleanup
* Mark ec2_classic_lb tests unstable
* Add more comments about why tests aren't enabled

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cb55efa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinabuzachis alinabuzachis alinabuzachis approved these changes

@ansible-zuul ansible-zuul[bot] ansible-zuul[bot] approved these changes

@tremble tremble tremble approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug community_review module module plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<RoleName> doesn't render in the generated html docs
5 participants
@mandar242 @ansibullbot @tremble @alinabuzachis @jillr