ec2_transit_gateway_vpc_attachment - Prepare module for migration to amazon.aws #2157
Conversation
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
|
Build succeeded. ❌ ansible-galaxy-importer FAILURE in 5m 00s (non-voting) |
There was a problem hiding this comment.
What about adding type hints to the functions?
Also, I noticed that module_utils.transitgateway imports some functionalities from community.aws.plugins.module_utils.ec2, whereas when we migrate this module, we may want to use the utilities from amazon.aws.plugins.module_utils.ec2.
I would suggest checking how these can be replaced/upgraded and if possible.
from ansible_collections.community.aws.plugins.module_utils.ec2 import BaseEc2Manager
from ansible_collections.community.aws.plugins.module_utils.ec2 import Boto3Mixin
from ansible_collections.community.aws.plugins.module_utils.ec2 import Ec2WaiterFactory
|
Build failed. ❌ ansible-galaxy-importer FAILURE in 6m 06s (non-voting) |
alinabuzachis
force-pushed
the
prep_tgw_vpc_att
branch
from
8c69f03 to
0bde16c
Compare
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 8m 37s (non-voting) |
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 3m 21s (non-voting) |
alinabuzachis
force-pushed
the
prep_tgw_vpc_att
branch
2 times, most recently
from
f7f287a to
f822de7
Compare
|
Build failed. ❌ ansible-galaxy-importer FAILURE in 5m 18s (non-voting) |
alinabuzachis
force-pushed
the
prep_tgw_vpc_att
branch
from
04e248f to
ee67c12
Compare
|
Build failed. ❌ ansible-galaxy-importer FAILURE in 4m 50s (non-voting) |
|
recheck |
|
Build failed. ❌ ansible-galaxy-importer FAILURE in 4m 28s (non-voting) |
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 3m 29s (non-voting) |
alinabuzachis
force-pushed
the
prep_tgw_vpc_att
branch
from
6438f5b to
85ba284
Compare
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 3m 19s (non-voting) |
|
recheck |
|
Build failed. ❌ ansible-galaxy-importer FAILURE in 5m 04s (non-voting) |
|
Build failed. ❌ ansible-galaxy-importer FAILURE in 4m 40s (non-voting) |
Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
alinabuzachis
force-pushed
the
prep_tgw_vpc_att
branch
from
eccf4a5 to
c218fe5
Compare
|
Build failed.
|
|
recheck |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 47s (non-voting) |
|
Build succeeded (gate pipeline). ❌ ansible-galaxy-importer FAILURE in 4m 47s (non-voting) |
softwarefactory-project-zuul
bot
merged commit 7dabfcc
into
ansible-collections:main
…amazon.aws (ansible-collections#2157) SUMMARY Refer: https://issues.redhat.com/browse/ACA-1868 This PR refactors and adds necessary documentation to ec2_transit_gateway_vpc_attachment and ec2_transit_gateway_vpc_attachment_info ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis Reviewed-by: Bikouo Aubin
…amazon.aws (ansible-collections#2157) SUMMARY Refer: https://issues.redhat.com/browse/ACA-1868 This PR refactors and adds necessary documentation to ec2_transit_gateway_vpc_attachment and ec2_transit_gateway_vpc_attachment_info ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis Reviewed-by: Bikouo Aubin
SUMMARY
Refer: https://issues.redhat.com/browse/ACA-1868
This PR refactors and adds necessary documentation to ec2_transit_gateway_vpc_attachment and ec2_transit_gateway_vpc_attachment_info
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION