-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add module_util support for transit gateway vpc attachment module #2314
Conversation
308577f
to
da30891
Compare
f946f12
to
5499aa0
Compare
recheck |
recheck |
5499aa0
to
9187ea4
Compare
@EC2TransitGatewayVPCAttachmentErrorHandler.common_error_handler("create transit gateway vpc attachment") | ||
@AWSRetry.jittered_backoff() | ||
def create_vpc_attachment( | ||
client, **params: Dict[str, Union[List[str], bool, List[Dict[str, Union[str, List[str]]]]]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
client, **params: Dict[str, Union[List[str], bool, List[Dict[str, Union[str, List[str]]]]]] | |
client, transit_gateway_id: str, vpc_id: str, subnet_ids: List[str], **params: Dict[str, Union[List[str], bool, List[Dict[str, Union[str, List[str]]]]]] |
plugins/module_utils/ec2.py
Outdated
client, **params: Dict[str, Union[List[str], bool, List[Dict[str, Union[str, List[str]]]]]] | ||
) -> Optional[Dict[str, Any]]: | ||
result = client.modify_transit_gateway_vpc_attachment(**params) | ||
return result.get("TransitGatewayVpcAttachment", None) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
client, **params: Dict[str, Union[List[str], bool, List[Dict[str, Union[str, List[str]]]]]] | |
) -> Optional[Dict[str, Any]]: | |
result = client.modify_transit_gateway_vpc_attachment(**params) | |
return result.get("TransitGatewayVpcAttachment", None) | |
client, transit_gateway_attachment_id: str, **params: Dict[str, Union[List[str], bool, List[Dict[str, Union[str, List[str]]]]]] | |
) -> Dict[str, Any]: | |
return client.modify_transit_gateway_vpc_attachment(**params)["TransitGatewayVpcAttachment"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
transit_gateway_attachment_id
is already passed inside params.
8dad194
to
3554094
Compare
Build failed.
|
Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
e1a3726
to
18531d0
Compare
Build failed.
|
Build failed.
|
recheck |
regate |
regate |
SUMMARY
This PR adds support waiter and functinality support for transit gateway vpc attachment module.
This is needed for ansible-collections/community.aws#2157
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION