[PR #2140/87e21522 backport][stable-8] ec2_vpc_vgw - fix call to parent static method in class VGWRetry #2141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
SUMMARY When trying to create a VPN virtual gateway with a non-existent VPC id, module fails incorrectly with the following error \\"/tmp/ansible_community.aws.ec2_vpc_vgw_payload_t4kolii1/ansible_community.aws.ec2_vpc_vgw_payload.zip/ansible_collections/community/aws/plugins/modules/ec2_vpc_vgw.py\\", line 173, in found\\nTypeError: super(type, obj): obj must be an instance or subtype of type The fix consists in adding argument to super() ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_vpc_vgw Reviewed-by: Mark Chappell (cherry picked from commit 87e2152)
tremble
approved these changes
Sep 9, 2024
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 59s (non-voting) |
abikouo
approved these changes
Sep 9, 2024
|
Build succeeded (gate pipeline). ❌ ansible-galaxy-importer FAILURE in 4m 46s (non-voting) |
softwarefactory-project-zuul
bot
merged commit 4ccc0bd
into
stable-8
63 of 67 checks passed
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-8/87e2152254b35949343df70c8fc68af3825573a6/pr-2140
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #2140 as merged into main (87e2152).
SUMMARY
When trying to create a VPN virtual gateway with a non-existent VPC id, module fails incorrectly with the following error
The fix consists in adding argument to
super()ISSUE TYPE
COMPONENT NAME
ec2_vpc_vgw