Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ec2_vpc_vgw - fix call to parent static method in class VGWRetry #2140

Conversation

abikouo
Copy link
Contributor

@abikouo abikouo commented Sep 9, 2024

SUMMARY

When trying to create a VPN virtual gateway with a non-existent VPC id, module fails incorrectly with the following error

\\"/tmp/ansible_community.aws.ec2_vpc_vgw_payload_t4kolii1/ansible_community.aws.ec2_vpc_vgw_payload.zip/ansible_collections/community/aws/plugins/modules/ec2_vpc_vgw.py\\", line 173, in found\\nTypeError: super(type, obj): obj must be an instance or subtype of type

The fix consists in adding argument to super()

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ec2_vpc_vgw

Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/81202739e47d4a459fe6d91e3fcb8f36

✔️ ansible-galaxy-importer SUCCESS in 3m 19s (non-voting)
✔️ build-ansible-collection SUCCESS in 11m 20s
✔️ ansible-test-splitter SUCCESS in 5m 16s
✔️ integration-community.aws-1 SUCCESS in 6m 50s
Skipped 21 jobs

@tremble tremble added backport-8 mergeit Merge the PR (SoftwareFactory) labels Sep 9, 2024
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/c11f8a5e0f2840bbb99585af18456bc0

ansible-galaxy-importer FAILURE in 4m 37s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 41s
✔️ ansible-test-splitter SUCCESS in 4m 20s
✔️ integration-community.aws-1 SUCCESS in 8m 23s
Skipped 21 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 87e2152 into ansible-collections:main Sep 9, 2024
90 of 96 checks passed
Copy link

patchback bot commented Sep 9, 2024

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/87e2152254b35949343df70c8fc68af3825573a6/pr-2140

Backported as #2141

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Sep 9, 2024
SUMMARY

When trying to create a VPN virtual gateway with a non-existent VPC id, module fails incorrectly with the following error
\\"/tmp/ansible_community.aws.ec2_vpc_vgw_payload_t4kolii1/ansible_community.aws.ec2_vpc_vgw_payload.zip/ansible_collections/community/aws/plugins/modules/ec2_vpc_vgw.py\\", line 173, in found\\nTypeError: super(type, obj): obj must be an instance or subtype of type

The fix consists in adding argument to super()

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

ec2_vpc_vgw

Reviewed-by: Mark Chappell
(cherry picked from commit 87e2152)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Sep 9, 2024
…) (#2141)

This is a backport of PR #2140 as merged into main (87e2152).
SUMMARY

When trying to create a VPN virtual gateway with a non-existent VPC id, module fails incorrectly with the following error
\\"/tmp/ansible_community.aws.ec2_vpc_vgw_payload_t4kolii1/ansible_community.aws.ec2_vpc_vgw_payload.zip/ansible_collections/community/aws/plugins/modules/ec2_vpc_vgw.py\\", line 173, in found\\nTypeError: super(type, obj): obj must be an instance or subtype of type

The fix consists in adding argument to super()

ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

ec2_vpc_vgw

Reviewed-by: Mark Chappell
Reviewed-by: Bikouo Aubin
@abikouo abikouo deleted the ec2_vpc_vgw_0909 branch October 15, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8 mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants