Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #1839/af18bc61 backport][stable-7] Eliminate escape codes in aws_ssm output from newer versions of Bash #2030

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Jan 3, 2024

This is a backport of PR #1839 as merged into main (af18bc6).

SUMMARY

aws_ssm - prevent escape codes from interfering with output

Fixes #1756

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

aws_ssm

ADDITIONAL INFORMATION

This disables the Readline feature enable-bracketed-paste which is enabled by default on Bash 5.1 and above. This was causing escape sequences like \x1b[?2004h\x1b[?2004l to get into the output from some operating systems (e.g. Amazon Linux).

…1839)

SUMMARY

aws_ssm - prevent escape codes from interfering with output

Fixes #1756

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

aws_ssm

ADDITIONAL INFORMATION

This disables the Readline feature enable-bracketed-paste which is enabled by default on Bash 5.1 and above. This was causing escape sequences like \x1b[?2004h\x1b[?2004l to get into the output from some operating systems (e.g. Amazon Linux).

(cherry picked from commit af18bc6)
@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jan 3, 2024
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/20997b3aad6d486eafd4c42b2d3d66ab

ansible-galaxy-importer FAILURE in 4m 47s (non-voting)
✔️ build-ansible-collection SUCCESS in 15m 18s
✔️ ansible-test-splitter SUCCESS in 6m 24s
✔️ integration-community.aws-1 SUCCESS in 9m 04s
✔️ integration-community.aws-2 SUCCESS in 10m 12s
✔️ integration-community.aws-3 SUCCESS in 5m 43s
Skipped 19 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 60f2861 into stable-7 Jan 3, 2024
57 of 73 checks passed
@softwarefactory-project-zuul softwarefactory-project-zuul bot deleted the patchback/backports/stable-7/af18bc61c94003c146a31200c17b0b9cb0651823/pr-1839 branch January 3, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants