Eliminate escape codes in aws_ssm output from newer versions of Bash #1839
Conversation
|
Could any of the maintainers help me review this please? cc @alinabuzachis @tremble |
|
recheck |
|
I have tested in our environment against several OS versions and it fixes the root problem. Please approve this and merge it. |
|
recheck |
|
Build succeeded. ❌ ansible-galaxy-importer FAILURE in 6m 14s (non-voting) |
|
what needs to be done to get this approved? PRs are taking a long time to get approved even though we've got several people saying it has fixed their problem. |
ansibullbot
added
bug
|
@dennisjlee this PR contains the following merge commits: Please rebase your branch to remove these commits. |
ansibullbot
added
merge_commit
|
bot_status |
dennisjlee
force-pushed
the
dj/disableBracketedPaste
branch
from
71940e9 to
3fc0fce
Compare
|
bot_status |
Componentschangelogs/fragments/1839-disable-bracketed-paste.yml plugins/connection/aws_ssm.py Metadatawaiting_on: maintainer |
ansibullbot
removed
the
merge_commit
|
I'm not sure why, but the maintainers don't seem to be willing to merge these kinds of changes. I've tried in the past to fix problems but they never got approved. What i've started doing is to keep a local copy of the plugin in my repository. You can just create a folder in the root called 'connection_plugins' and then copy the file into this folder with the needed changes. Then in the playbook, set a variable called 'ansible_connection: filename' (don't include the extention). This allows ansible to use your local copy of the playbook and you can update it with any fixes that are not being included. |
|
Hi, |
@simon97k I have no idea, sorry. I have not had any engagement from maintainers of this project after getting approvals earlier this year. I do not know what else is needed to get this merged. Any guidance from maintainers would be appreciated! |
|
Hi @alinabuzachis , @hakbailey , any chance of getting this merged soon? |
|
Guess we wont' see progress on this in 2023? Shall we wait for Amazon Linux 2024 to get released? |
|
recheck |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 51s (non-voting) |
|
@alinabuzachis and @hakbailey - the tests finally passed on this branch. Would either of you mind merging this please? It would be great to get this fixed - it's been more than 7 months since I opened the PR. |
tremble
added
backport-7
|
Based on #1793 this appears to be working for CentOS 9, Ubuntu and Amazon Linux 2. There exists a risk that this might break older OSes, however with CentOS 8 now EOL we don't have the ability to test this. |
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 4m 25s (non-voting) |
|
Pull request merge failed: Resource not accessible by integration, You may need to manually rebase your PR and retry. |
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #2029 🤖 @patchback |
…1839) SUMMARY aws_ssm - prevent escape codes from interfering with output Fixes #1756 ISSUE TYPE Bugfix Pull Request COMPONENT NAME aws_ssm ADDITIONAL INFORMATION This disables the Readline feature enable-bracketed-paste which is enabled by default on Bash 5.1 and above. This was causing escape sequences like \x1b[?2004h\x1b[?2004l to get into the output from some operating systems (e.g. Amazon Linux). (cherry picked from commit af18bc6)
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #2030 🤖 @patchback |
…1839) SUMMARY aws_ssm - prevent escape codes from interfering with output Fixes #1756 ISSUE TYPE Bugfix Pull Request COMPONENT NAME aws_ssm ADDITIONAL INFORMATION This disables the Readline feature enable-bracketed-paste which is enabled by default on Bash 5.1 and above. This was causing escape sequences like \x1b[?2004h\x1b[?2004l to get into the output from some operating systems (e.g. Amazon Linux). (cherry picked from commit af18bc6)
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
|
and there was much rejoicing! |
|
Thank you @tremble! |
…1839) (#2030) [PR #1839/af18bc61 backport][stable-7] Eliminate escape codes in aws_ssm output from newer versions of Bash This is a backport of PR #1839 as merged into main (af18bc6). SUMMARY aws_ssm - prevent escape codes from interfering with output Fixes #1756 ISSUE TYPE Bugfix Pull Request COMPONENT NAME aws_ssm ADDITIONAL INFORMATION This disables the Readline feature enable-bracketed-paste which is enabled by default on Bash 5.1 and above. This was causing escape sequences like \x1b[?2004h\x1b[?2004l to get into the output from some operating systems (e.g. Amazon Linux). Reviewed-by: Mark Chappell
|
Sorry it took so long, the (full) integration tests for this plugin were broken when they took down the Fedora image it was using. Having previously spent way too long trying to get the test suite working I didn't have the time/energy to try and fix them at the time (not my plugin, I'm just a community maintainer who generally cares about things like the integration tests). In #1793 I'm bumping them over to CentOS 9 because the cycle's longer and causes less pain. There exists a small risk that this PR will break compatibility with pre-bash-5.1 OSes, but I think the benefits outweigh the risks at this point. community.aws 7.2 is due to be released "about now", so hopefully this fix will be available on galaxy in the not-too-distant future... |
|
thank you for the work you do and the effort to get this fixed |
|
@dennisjlee You are a LEGEND! |
SUMMARY
aws_ssm - prevent escape codes from interfering with output
Fixes #1756
ISSUE TYPE
Bugfix Pull Request
COMPONENT NAME
aws_ssm
ADDITIONAL INFORMATION
This disables the Readline feature
enable-bracketed-pastewhich is enabled by default on Bash 5.1 and above. This was causing escape sequences like\x1b[?2004h\x1b[?2004lto get into the output from some operating systems (e.g. Amazon Linux).