[PR #1994/5248e3ff backport][stable-7] eks_nodegroup - wait for deletion of both node groups #1995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
eks_nodegroup - wait for deletion of both node groups SUMMARY Fixes eks_nodegroup integration test. Ensure eks_nodegroup waits for deletion when wait=True including when the node group was already in deletING state. ISSUE TYPE Feature Pull Request COMPONENT NAME eks_nodegroup ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis (cherry picked from commit 5248e3f)
|
Build succeeded. ❌ ansible-galaxy-importer FAILURE in 4m 59s (non-voting) |
tremble
approved these changes
Nov 6, 2023
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 4m 45s (non-voting) |
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-7/5248e3ff825ed7643a143f669de068cd28315e4a/pr-1994
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #1994 as merged into main (5248e3f).
SUMMARY
Fixes eks_nodegroup integration test.
Ensure eks_nodegroup waits for deletion when
wait=Trueincluding when the node group was already in deletING state.ISSUE TYPE
COMPONENT NAME
eks_nodegroup
ADDITIONAL INFORMATION