Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eks_nodegroup - wait for deletion of both node groups #1994

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Nov 4, 2023

SUMMARY

Fixes eks_nodegroup integration test.
Ensure eks_nodegroup waits for deletion when wait=True including when the node group was already in deletING state.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

eks_nodegroup

ADDITIONAL INFORMATION

@tremble tremble marked this pull request as ready for review November 4, 2023 21:10
@tremble tremble requested a review from alinabuzachis November 4, 2023 21:10
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/e3f3e07fe6a148aab1f4c5c6c0cfa36e

ansible-galaxy-importer FAILURE in 5m 03s (non-voting)
✔️ build-ansible-collection SUCCESS in 15m 32s
✔️ ansible-test-splitter SUCCESS in 5m 42s
✔️ integration-community.aws-1 SUCCESS in 28m 14s
Skipped 21 jobs

@tremble tremble added the backport-7 PR should be backported to the stable-7 branch label Nov 5, 2023
@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Nov 6, 2023
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/273cac88fa9f46d0a2c9da8a5136d673

✔️ ansible-galaxy-importer SUCCESS in 4m 43s (non-voting)
✔️ build-ansible-collection SUCCESS in 14m 48s
✔️ ansible-test-splitter SUCCESS in 5m 29s
✔️ integration-community.aws-1 SUCCESS in 27m 25s
Skipped 21 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 5248e3f into ansible-collections:main Nov 6, 2023
78 checks passed
Copy link

patchback bot commented Nov 6, 2023

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/5248e3ff825ed7643a143f669de068cd28315e4a/pr-1994

Backported as #1995

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 6, 2023
eks_nodegroup - wait for deletion of both node groups

SUMMARY
Fixes eks_nodegroup integration test.
Ensure eks_nodegroup waits for deletion when wait=True including when the node group was already in deletING state.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
eks_nodegroup
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis
(cherry picked from commit 5248e3f)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Nov 6, 2023
[PR #1994/5248e3ff backport][stable-7] eks_nodegroup - wait for deletion of both node groups

This is a backport of PR #1994 as merged into main (5248e3f).
SUMMARY
Fixes eks_nodegroup integration test.
Ensure eks_nodegroup waits for deletion when wait=True including when the node group was already in deletING state.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
eks_nodegroup
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell
tremble added a commit to alinabuzachis/community.aws that referenced this pull request Nov 6, 2023
@tremble tremble deleted the eks_nodegroup/wait_delete branch January 12, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-7 PR should be backported to the stable-7 branch mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants