Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #1910/9a9c8c58 backport][stable-5] opensearch: avoid a KeyError during the DomainConfig reading #1922

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Aug 31, 2023

This is a backport of PR #1910 as merged into main (9a9c8c5).

This commit avoids a KeyError exception in get_domain_config().
Some entries from DomainConfig don't have any Options key. For instance, ChangeProgressDetails.

See:

Closes: #1907

opensearch: avoid a KeyError during the DomainConfig reading

This commit avoids a KeyError exception in get_domain_config().
Some entries from DomainConfig don't have any Options key. For instance, ChangeProgressDetails.
See:

https://docs.aws.amazon.com/opensearch-service/latest/APIReference/API_DomainConfig.html
https://docs.aws.amazon.com/opensearch-service/latest/APIReference/API_ChangeProgressDetails.html

Closes: #1907

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Alina Buzachis
(cherry picked from commit 9a9c8c5)
@ansibullbot
Copy link

@patchback[bot]: Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information.

Here are the items we could not find in your description:

  • issue type

Please set the description of this pullrequest with this template:
https://raw.githubusercontent.com/ansible/ansible/devel/.github/PULL_REQUEST_TEMPLATE.md

click here for bot help

@ansibullbot ansibullbot added needs_info This issue requires further information. Please answer any outstanding questions needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly needs_triage new_contributor Help guide this first time contributor small_patch Hopefully easy to review labels Aug 31, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/9c74c5f5cc444540b8212ad014d85ed4

ansible-galaxy-importer FAILURE in 6m 09s (non-voting)
✔️ build-ansible-collection SUCCESS in 12m 56s
✔️ ansible-test-splitter SUCCESS in 5m 17s
Skipped 22 jobs

@alinabuzachis alinabuzachis added the mergeit Merge the PR (SoftwareFactory) label Sep 1, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/9b7087cde19046d78e73993445665df5

ansible-galaxy-importer FAILURE in 5m 22s (non-voting)
✔️ build-ansible-collection SUCCESS in 12m 34s
✔️ ansible-test-splitter SUCCESS in 4m 51s
Skipped 22 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 348930a into stable-5 Sep 1, 2023
@softwarefactory-project-zuul softwarefactory-project-zuul bot deleted the patchback/backports/stable-5/9a9c8c58b3120d3f1988030cf8a31662a992c335/pr-1910 branch September 1, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit Merge the PR (SoftwareFactory) needs_info This issue requires further information. Please answer any outstanding questions needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly needs_triage new_contributor Help guide this first time contributor small_patch Hopefully easy to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants