-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opensearch: avoid a KeyError during the DomainConfig reading #1910
opensearch: avoid a KeyError during the DomainConfig reading #1910
Conversation
4cc3011
to
b2da543
Compare
@goneri: Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information. Here are the items we could not find in your description:
Please set the description of this pullrequest with this template: |
Build succeeded. ❌ ansible-galaxy-importer FAILURE in 4m 32s (non-voting) |
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 3m 43s (non-voting) |
Pull request merge failed: Resource not accessible by integration, You may need to manually rebase your PR and retry. |
@goneri Can you please rebase? |
This commit avoids a KeyError exception in `get_domain_config()`. Some entries from DomainConfig don't have any `Options` key. For instance, `ChangeProgressDetails`. See: - https://docs.aws.amazon.com/opensearch-service/latest/APIReference/API_DomainConfig.html - https://docs.aws.amazon.com/opensearch-service/latest/APIReference/API_ChangeProgressDetails.html
b2da543
to
1aab201
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 31s (non-voting) |
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 3m 45s (non-voting) |
Backport to stable-5: 💚 backport PR created✅ Backport PR branch: Backported as #1922 🤖 @patchback |
opensearch: avoid a KeyError during the DomainConfig reading This commit avoids a KeyError exception in get_domain_config(). Some entries from DomainConfig don't have any Options key. For instance, ChangeProgressDetails. See: https://docs.aws.amazon.com/opensearch-service/latest/APIReference/API_DomainConfig.html https://docs.aws.amazon.com/opensearch-service/latest/APIReference/API_ChangeProgressDetails.html Closes: #1907 Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis (cherry picked from commit 9a9c8c5)
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #1923 🤖 @patchback |
opensearch: avoid a KeyError during the DomainConfig reading This commit avoids a KeyError exception in get_domain_config(). Some entries from DomainConfig don't have any Options key. For instance, ChangeProgressDetails. See: https://docs.aws.amazon.com/opensearch-service/latest/APIReference/API_DomainConfig.html https://docs.aws.amazon.com/opensearch-service/latest/APIReference/API_ChangeProgressDetails.html Closes: #1907 Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis (cherry picked from commit 9a9c8c5)
…1923) [PR #1910/9a9c8c58 backport][stable-6] opensearch: avoid a KeyError during the DomainConfig reading This is a backport of PR #1910 as merged into main (9a9c8c5). This commit avoids a KeyError exception in get_domain_config(). Some entries from DomainConfig don't have any Options key. For instance, ChangeProgressDetails. See: https://docs.aws.amazon.com/opensearch-service/latest/APIReference/API_DomainConfig.html https://docs.aws.amazon.com/opensearch-service/latest/APIReference/API_ChangeProgressDetails.html Closes: #1907 Reviewed-by: Alina Buzachis
…1922) [PR #1910/9a9c8c58 backport][stable-5] opensearch: avoid a KeyError during the DomainConfig reading This is a backport of PR #1910 as merged into main (9a9c8c5). This commit avoids a KeyError exception in get_domain_config(). Some entries from DomainConfig don't have any Options key. For instance, ChangeProgressDetails. See: https://docs.aws.amazon.com/opensearch-service/latest/APIReference/API_DomainConfig.html https://docs.aws.amazon.com/opensearch-service/latest/APIReference/API_ChangeProgressDetails.html Closes: #1907 Reviewed-by: Alina Buzachis
This commit avoids a KeyError exception in
get_domain_config()
.Some entries from DomainConfig don't have any
Options
key. For instance,ChangeProgressDetails
.See:
Closes: #1907